Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mapping for edge connector for N3 #6373

Merged
merged 2 commits into from
Mar 22, 2024
Merged

add mapping for edge connector for N3 #6373

merged 2 commits into from
Mar 22, 2024

Conversation

tballmsft
Copy link
Contributor

@tballmsft tballmsft commented Mar 22, 2024

fix for #3699

@tballmsft tballmsft requested review from mmoskal and removed request for eanders-ms March 22, 2024 18:44
@tballmsft
Copy link
Contributor Author

tballmsft commented Mar 22, 2024

@mmoskal - the config for N3 was missing pin mappings for P1-20 (the edge connector, I think). I copied the mapping over from codal-microbit-v2. Can you please check?

https://github.com/lancaster-university/codal-microbit-v2/blob/08ba1e75fa86b2f4807a87e6b555e0efb1e712a8/model/MicroBitIO.h#L222

@mmoskal
Copy link
Member

mmoskal commented Mar 22, 2024

most of these pins are unavailable when the shield is connected

@tballmsft
Copy link
Contributor Author

got it. some of the shields make them accessible. probably best to just have all the mappings,

@tballmsft tballmsft merged commit 13ebb9f into master Mar 22, 2024
3 checks passed
@tballmsft tballmsft deleted the microbitPinMapping branch March 22, 2024 18:54
@tballmsft tballmsft restored the microbitPinMapping branch March 22, 2024 18:55
@tballmsft
Copy link
Contributor Author

Well, except for the ones used by the shield....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants