Support get/set_vp_register for synic registers #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
commented
Nov 15, 2024
| .as_mut() | ||
| .unwrap() | ||
| .read_nontimer_msr(msr), | ||
| _ => self.backing.untrusted_synic.as_mut().unwrap().read_msr(msr), |
There was a problem hiding this comment.
Is it ok for these TDX paths to have access to the timer registers on the untrusted_synic?
smalis-msft
commented
Nov 15, 2024
| @@ -1883,7 +1883,17 @@ macro_rules! registers { | |||
| Sifp = 0x000A0012, | |||
| Sipp = 0x000A0013, | |||
| Eom = 0x000A0014, | |||
| Sirbp = 0x000A0015, | |||
There was a problem hiding this comment.
I removed this register because not only do we never use it, but neither does the hcl. Makes things here a bit clearer I think, that we explicitly do not support this register today.
There was a problem hiding this comment.
hvdef is for definitions and should not reflect what we actually support in any crate that consumes it.
smalis-msft
force-pushed
the
synic_regs
branch
from
df9cb3c
to
c8dc6b8
Compare
|
This is fine conceptually, but do x64 guests actually try to access synic registers this way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this by just converting the register index to an msr index and calling the existing read/write msr functions. This comes along with a refactor to the timer MSRs to move their control inside the synic, making read/write_msr more complete.
A follow up PR will tackle the VINA register (would conflict with #248) and the apic base register.