Use VTL-aware direct hypercall to get/set registers when possible #125
+599
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stunes-ms
force-pushed
the
user/mikestunes/get-set-vtl
branch
from
62d8c75
to
7b2f4d2
Compare
|
Probably don't want to merge this until the VMM tests are back online, given that past iterations have definitely broken them |
sluck-msft
reviewed
Oct 21, 2024
stunes-ms
force-pushed
the
user/mikestunes/get-set-vtl
branch
2 times, most recently
from
341b249
to
fff8705
Compare
smalis-msft
previously approved these changes
Oct 25, 2024
|
2024-10-25T17:36:30.4833152Z 2024-10-25T17:36:23.768666Z INFO openvmm_log: 18.837411200s INFO underhill_log: inner_level="6" inner_target="kmsg" "[U] task 'set_idle_task', thread 'tp' panicked at openhcl/hcl/src/ioctl.rs:1238:17:" fields={} extra={"timestamp": "16.373058000s"} |
stunes-ms
force-pushed
the
user/mikestunes/get-set-vtl
branch
from
fff8705
to
7a07050
Compare
smalis-msft
reviewed
Oct 29, 2024
smalis-msft
previously approved these changes
Oct 29, 2024
sluck-msft
reviewed
Oct 30, 2024
stunes-ms
force-pushed
the
user/mikestunes/get-set-vtl
branch
from
a67516a
to
511e94d
Compare
stunes-ms
commented
Nov 2, 2024
smalis-msft
reviewed
Nov 4, 2024
smalis-msft
reviewed
Nov 4, 2024
sluck-msft
reviewed
Nov 4, 2024
stunes-ms
force-pushed
the
user/mikestunes/get-set-vtl
branch
from
511e94d
to
e76c720
Compare
sluck-msft
reviewed
Nov 5, 2024
sluck-msft
previously approved these changes
Nov 5, 2024
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
jstarks
reviewed
Nov 7, 2024
Thanks John! Will handle batching and adding TODO comments tomorrow. |
stunes-ms
force-pushed
the
user/mikestunes/get-set-vtl
branch
from
b363255
to
815206c
Compare
Modify ProcessorRunner::get_reg and ProcessorRunner::set_reg to use a direct hypercall when possible, instead of our dedicated get/set-register ioctl. Certain registers have special handling in the kernel ioctl handler. Those are left as-is. Get/set for other registers is now made with a direct hypercall. This has the benefit of being VTL-aware, so this change also adds a VTL parameter. This change also removes some proliferation of (g|s)et_vp_registers?(_inner)?, hopefully making it simpler and cleaner. The singular (g|s)et_vp_register is left as an ergonomic convenience. One unaddressed capability is making ioctls/hypercalls on a batch of registers. This is not strictly a regression, because MSHV_VP_MAX_REGISTERS was previously 1.
stunes-ms
force-pushed
the
user/mikestunes/get-set-vtl
branch
from
2d344f0
to
9c8c7ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify ProcessorRunner::get_reg and ProcessorRunner::set_reg to use a direct hypercall when possible, instead of our dedicated get/set-register ioctl. Certain registers have special handling in the kernel ioctl handler. Those are left as-is. Get/set for other registers is now made with a direct hypercall.
This has the benefit of being VTL-aware, so this change also adds a VTL parameter.
This change also removes some proliferation of
(g|s)et_vp_registers?(_inner)?, hopefully making it simpler and cleaner. The singular (g|s)et_vp_register is left as an ergonomic convenience.
One unaddressed capability is making ioctls/hypercalls on a batch of registers. This is not strictly a regression, because MSHV_VP_MAX_REGISTERS was previously 1.