Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opset19 | chore(torchlib) #880

Closed
wants to merge 5 commits into from
Closed

Conversation

justinchuby
Copy link
Collaborator

Depends on torch.onnx adding the opset19 enum.

@justinchuby justinchuby requested a review from BowenBao July 17, 2023 16:01
@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jul 17, 2023
@justinchuby justinchuby removed the request for review from BowenBao August 9, 2023 18:35
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #880 (8f14056) into main (5b50753) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
- Coverage   78.40%   78.27%   -0.14%     
==========================================
  Files         118      118              
  Lines       15030    15030              
  Branches     1601     1601              
==========================================
- Hits        11785    11765      -20     
- Misses       2874     2895      +21     
+ Partials      371      370       -1     
Files Coverage Δ
onnxscript/function_libs/torch_lib/ops/core.py 79.71% <100.00%> (ø)
onnxscript/function_libs/torch_lib/ops/nn.py 80.24% <100.00%> (ø)
onnxscript/function_libs/torch_lib/ops/prims.py 50.18% <100.00%> (ø)
onnxscript/function_libs/torch_lib/ops/special.py 61.94% <100.00%> (ø)

... and 6 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results

         18 files  ±           0         18 suites  ±0   3h 21m 51s ⏱️ + 2h 4m 50s
  11 099 tests  -            1    7 909 ✔️  -      421      2 562 💤  -        159         628 +       579 
449 922 runs  +290 834  72 785 ✔️ +36 270  229 327 💤 +108 792  147 810 +145 772 

For more details on these failures, see this check.

Results for commit 8f14056. ± Comparison against base commit 5b50753.

This pull request removes 1 test.
docs.test.test_documentation_examples.TestDocumentationExample ‑ test_documentation_examples

♻️ This comment has been updated with latest results.

@justinchuby justinchuby marked this pull request as draft August 9, 2023 20:36
@justinchuby justinchuby closed this May 5, 2024
@justinchuby justinchuby deleted the justinchu/use-opset19 branch May 5, 2024 14:52
@justinchuby justinchuby restored the justinchu/use-opset19 branch May 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant