Fix missing type in _add_attribute_to_torchscript_node for Deberta models #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dels Signed-off-by: Xavier Dupre <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
onnxscript/function_libs/torch_lib/graph_building/_graph_building_torch.py
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
==========================================
- Coverage 75.11% 75.10% -0.01%
==========================================
Files 245 245
Lines 26517 26519 +2
Branches 4834 4835 +1
==========================================
Hits 19918 19918
- Misses 5670 5671 +1
- Partials 929 930 +1 ☔ View full report in Codecov by Sentry. |
onnxscript/function_libs/torch_lib/graph_building/_graph_building_torch.py
Fixed
Show fixed
Hide fixed
onnxscript/function_libs/torch_lib/graph_building/_graph_building_torch.py
Fixed
Show fixed
Hide fixed
justinchuby
reviewed
Aug 5, 2024
onnxscript/function_libs/torch_lib/graph_building/_graph_building_torch.py
Outdated
Show resolved
Hide resolved
justinchuby
reviewed
Aug 5, 2024
onnxscript/function_libs/torch_lib/graph_building/_graph_building_torch.py
Show resolved
Hide resolved
Signed-off-by: Xavier Dupre <[email protected]>
justinchuby
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.