Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Fix error message with remove(..., safe=True) #1768

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Aug 1, 2024

Previously the node printed was incorrect.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.06%. Comparing base (a7835f2) to head (1f194b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1768   +/-   ##
=======================================
  Coverage   75.06%   75.06%           
=======================================
  Files         245      245           
  Lines       26437    26436    -1     
  Branches     4822     4822           
=======================================
+ Hits        19844    19845    +1     
+ Misses       5662     5660    -2     
  Partials      931      931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby changed the title Fix [IR] Fix error message with remove(..., safe=True) Aug 1, 2024
@justinchuby justinchuby requested a review from titaiwangms August 1, 2024 18:07
@justinchuby justinchuby marked this pull request as ready for review August 1, 2024 18:11
Copy link

github-actions bot commented Aug 1, 2024

Test Results

     24 files  ±     0      24 suites  ±0   3h 9m 48s ⏱️ - 8m 38s
 17 021 tests + 2 185  15 009 ✅ +1 748    1 980 💤 +   435   32 ❌ +2 
441 836 runs   - 35 708  94 872 ✅  - 5 258  346 694 💤  - 30 452  270 ❌ +2 

For more details on these failures, see this check.

Results for commit 1f194b2. ± Comparison against base commit a7835f2.

@justinchuby justinchuby merged commit 23e1fcb into main Aug 1, 2024
28 of 43 checks passed
@justinchuby justinchuby deleted the justinchu/ir-misc-safe branch August 1, 2024 18:51
@justinchuby justinchuby mentioned this pull request Aug 1, 2024
@justinchuby justinchuby added the topic: IR Intermediate representation label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: IR Intermediate representation
Projects
Development

Successfully merging this pull request may close these issues.

2 participants