[torchlib] Fix implementation for clamp_max / clamp_min #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
added
the
topic: torch_lib
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
==========================================
+ Coverage 75.01% 75.06% +0.05%
==========================================
Files 245 245
Lines 26451 26443 -8
Branches 4826 4824 -2
==========================================
+ Hits 19841 19850 +9
+ Misses 5677 5662 -15
+ Partials 933 931 -2 ☔ View full report in Codecov by Sentry. |
justinchuby
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
titaiwangms
approved these changes
Jul 30, 2024
There are tests because the pytorch operator supports that, but in practice I don't see that being meaningful because it's just doing an expand. We can come back to it when it becomes an issue. |
Test Results 24 files ± 0 24 suites ±0 3h 21m 28s ⏱️ + 2m 9s For more details on these failures, see this check. Results for commit dd574ae. ± Comparison against base commit 19f1126. This pull request removes 590 and adds 588 tests. Note that renamed tests count towards both.This pull request removes 134 skipped tests and adds 133 skipped tests. Note that renamed tests count towards both.This pull request skips 8 tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update clamp_max and clamp_min. Remove support for size-0 inputs to simplify the implementations. Fixed registration to make the operators discoverable.