Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torchlib] Fix linspace and full #1742

Merged
merged 10 commits into from
Jul 23, 2024
Merged

[torchlib] Fix linspace and full #1742

merged 10 commits into from
Jul 23, 2024

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Jul 22, 2024

  • linspace: Add additional parameters
  • full: Handle when size is []

@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.94%. Comparing base (3741ea5) to head (f45bd97).

Files Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 72.72% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1742      +/-   ##
==========================================
- Coverage   74.98%   74.94%   -0.04%     
==========================================
  Files         245      245              
  Lines       26381    26379       -2     
  Branches     4801     4802       +1     
==========================================
- Hits        19782    19771      -11     
- Misses       5680     5687       +7     
- Partials      919      921       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby changed the title [torchlib] Fix linspace and cast [torchlib] Fix linspace and full Jul 22, 2024
Copy link

Test Results

     24 files  ±    0      24 suites  ±0   3h 47m 54s ⏱️ + 29m 2s
 13 339 tests ±    0  11 795 ✅  - 14    1 499 💤 ±0     45 ❌ +   15 
480 665 runs  +8 257  98 906 ✅ + 1  373 234 💤 ±0  8 525 ❌ +8 257 

For more details on these failures, see this check.

Results for commit 9451bef. ± Comparison against base commit 9551e98.

@justinchuby justinchuby merged commit affaee0 into main Jul 23, 2024
31 of 41 checks passed
@justinchuby justinchuby deleted the justinchu/fix-cast branch July 23, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

3 participants