-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weekly CI pipeline errors #1741
Conversation
1. Fix type annotation for _add_attribute_to_torchscript_node and removed runtime type checking because int like inputs are not correctly recognized by beartype 2. Fix IR test errors with latest onnx-weekly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 74.89% 74.95% +0.05%
==========================================
Files 245 245
Lines 26367 26367
Branches 4796 4796
==========================================
+ Hits 19748 19763 +15
+ Misses 5697 5684 -13
+ Partials 922 920 -2 ☔ View full report in Codecov by Sentry. |
Test Results 24 files ± 0 24 suites ±0 3h 17m 43s ⏱️ + 1h 16m 17s For more details on these failures, see this check. Results for commit e6f02be. ± Comparison against base commit 427a809. This pull request removes 5753 and adds 6755 tests. Note that renamed tests count towards both.
This pull request removes 1820 skipped tests and adds 13 skipped tests. Note that renamed tests count towards both.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan on fixing the failing dort ci's in a future PR?
I don't have plans for it yet. The dort ci failures should be the same as the torch-nightly failures, which are mostly tolerance issues. |
test_tensor_proto_tensor_bfloat16
with latest onnx-weekly