Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torchlib] Fix registrations 3/n #1740

Merged
merged 15 commits into from
Jul 22, 2024
Merged

[torchlib] Fix registrations 3/n #1740

merged 15 commits into from
Jul 22, 2024

Conversation

justinchuby
Copy link
Collaborator

Fix more registration issues #1644

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.86%. Comparing base (3fc6ead) to head (c146817).

Files Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   74.87%   74.86%   -0.02%     
==========================================
  Files         245      245              
  Lines       26370    26367       -3     
  Branches     4795     4796       +1     
==========================================
- Hits        19744    19739       -5     
- Misses       5703     5705       +2     
  Partials      923      923              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jul 22, 2024
Copy link

Test Results

     24 files  ±    0      24 suites  ±0   2h 6m 27s ⏱️ + 5m 37s
 14 225 tests +1 284  10 572 ✅ +767    3 647 💤 +513    6 ❌ +  5 
311 520 runs  +  132  74 088 ✅  -  32  237 273 💤 + 15  159 ❌ +150 

For more details on these failures, see this check.

Results for commit c349f9b. ± Comparison against base commit 3fc6ead.

This pull request removes 2 and adds 1286 tests. Note that renamed tests count towards both.
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_flip
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_sym_size
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0000_test_slice_negative_axes
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0001_test_erf
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0002_test_identity_opt
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0003_test_and_bcast4v3d
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0004_test_maxpool_3d_dilations_use_ref_impl_large
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0005_test_quantizelinear_uint4
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0006_test_roialign_mode_max
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0007_test_layer_normalization_2d_axis_negative_2_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0008_test_gelu_tanh_1
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0009_test_asinh
…
This pull request skips 1 test.
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_097_aten_flip

@justinchuby justinchuby merged commit 427a809 into main Jul 22, 2024
27 of 41 checks passed
@justinchuby justinchuby deleted the justinchu/reg-add branch July 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants