Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torchlib] Fix registration typo in expm1 #1736

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[torchlib] Fix registration typo in expm1 #1736

merged 1 commit into from
Jul 18, 2024

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Jul 18, 2024

Also remove the default overload for unsafe_split because it does not exist.

@justinchuby justinchuby added topic: torch_lib Related to the torch/aten function lib in development merge at lgtm Reviewers can merge when they approve labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.89%. Comparing base (b043acf) to head (6b3e679).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1736   +/-   ##
=======================================
  Coverage   74.88%   74.89%           
=======================================
  Files         245      245           
  Lines       26360    26358    -2     
  Branches     4793     4793           
=======================================
+ Hits        19741    19742    +1     
+ Misses       5697     5695    -2     
+ Partials      922      921    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

     24 files  ±     0      24 suites  ±0   1h 50m 38s ⏱️ - 10m 55s
 13 930 tests ±     0  10 609 ✅  -     6    3 312 💤 ±     0   9 ❌ +7 
276 196 runs   - 17 590  68 957 ✅  - 2 584  207 222 💤  - 15 012  17 ❌ +7 

For more details on these failures, see this check.

Results for commit 6b3e679. ± Comparison against base commit b043acf.

@justinchuby justinchuby merged commit 2401de4 into main Jul 18, 2024
28 of 43 checks passed
@justinchuby justinchuby deleted the justinchu/reg branch July 18, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at lgtm Reviewers can merge when they approve topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants