Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torchlib] Add missing operators (set 2) #1733

Merged
merged 8 commits into from
Jul 18, 2024
Merged

[torchlib] Add missing operators (set 2) #1733

merged 8 commits into from
Jul 18, 2024

Conversation

shubhambhokare1
Copy link
Contributor

@shubhambhokare1 shubhambhokare1 commented Jul 17, 2024 •
edited
Loading

  • aten.special.expm1
  • aten.sort

@shubhambhokare1 shubhambhokare1 self-assigned this Jul 17, 2024
@shubhambhokare1 shubhambhokare1 added the topic: torch_lib Related to the torch/aten function lib in development label Jul 17, 2024
@shubhambhokare1 shubhambhokare1 mentioned this pull request Jul 17, 2024
Closed
@shubhambhokare1 shubhambhokare1 linked an issue Jul 17, 2024 that may be closed by this pull request
Dynamo export: unsupported FX node 'aten.expm1.default' pytorch/pytorch#129530
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.89%. Comparing base (9ced95d) to head (f8baeea).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
+ Coverage   74.87%   74.89%   +0.02%     
==========================================
  Files         244      244              
  Lines       26344    26353       +9     
  Branches     4788     4791       +3     
==========================================
+ Hits        19725    19738      +13     
+ Misses       5698     5694       -4     
  Partials      921      921

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Test Results

     24 files  ±     0      24 suites  ±0   1h 55m 45s ⏱️ - 5m 59s
 13 930 tests + 1 015  10 615 ✅ +  823    3 312 💤 +   190   3 ❌ +2 
293 786 runs   - 17 221  71 541 ✅  - 2 376  222 234 💤  - 14 847  11 ❌ +2 

For more details on these failures, see this check.

Results for commit f8baeea. ± Comparison against base commit 9ced95d.

This pull request removes 522 and adds 1537 tests. Note that renamed tests count towards both. 
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_094_aten_special_erfcx
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_095_aten_fill
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_096_aten_flip
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_097_aten_floor
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_098_aten_floor_divide
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_099_aten_fmod
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_100_aten_frac
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_101_aten_full
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_102_aten_full_like
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_103_aten_gather
…

onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0289_test_convtranspose_kernel_shape
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0290_test_convtranspose_output_shape
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0291_test_convtranspose_pad
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0292_test_convtranspose_pads
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0293_test_conv_with_autopad_same
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0294_test_conv_with_strides_and_asymmetric_padding
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0295_test_conv_with_strides_no_padding
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0296_test_conv_with_strides_padding
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0297_test_cos
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0298_test_cosh
…
This pull request removes 115 skipped tests and adds 349 skipped tests. Note that renamed tests count towards both. 
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_101_aten_full
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_102_aten_full_like
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_108_aten_index
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_109_aten_index_bool
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_121_aten_lift_fresh_copy
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_123_aten_linalg_vector_norm
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_124_aten_linspace
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_131_aten_special_log_softmax
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_147_aten_mH_complex
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_159_aten_native_dropout
…

onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0308_test_deform_conv_with_mask_bias
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0309_test_deform_conv_with_multiple_offset_groups
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0312_test_dequantizelinear
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0313_test_dequantizelinear_axis
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0314_test_dequantizelinear_blocked
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0315_test_dequantizelinear_e4m3fn
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0316_test_dequantizelinear_e4m3fn_float16
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0317_test_dequantizelinear_e4m3fn_zero_point
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0318_test_dequantizelinear_e5m2
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0319_test_dequantizelinear_int16
…

♻️ This comment has been updated with latest results.

@shubhambhokare1 shubhambhokare1 mentioned this pull request Jul 17, 2024
Closed
@shubhambhokare1 shubhambhokare1 linked an issue Jul 17, 2024 that may be closed by this pull request
[dynamo] aten::sort() is not supported by dynamo_export pytorch/pytorch#127831
Closed
@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/torchlib-sort branch from 3ee0d7e to 73ec353 Compare July 17, 2024 21:17
@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/torchlib-sort branch from f5a93f3 to 224a35f Compare July 17, 2024 23:27
justinchuby
justinchuby reviewed Jul 18, 2024
View reviewed changes
onnxscript/function_libs/torch_lib/ops/core.py
Comment on lines +7712 to +7713
dim_size = op.Gather(shape, dim, axis=0)
dim_size = op.Reshape(dim_size, op.Constant(value_ints=[1]))
Copy link
Collaborator

@justinchuby justinchuby Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a slice to replace the two ops? (slice is also more preferable than gather)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, think I missed this comment before merge. Making a note of this as a #TODO for the PR covering the next set of operators.

@shubhambhokare1 shubhambhokare1 merged commit d05d101 into main Jul 18, 2024
29 of 43 checks passed
@shubhambhokare1 shubhambhokare1 deleted the sbhokare/torchlib-sort branch July 18, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@gramalingam gramalingam gramalingam left review comments

Assignees

@shubhambhokare1 shubhambhokare1

Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
ONNX Script Review Board
Status: Done
Milestone
No milestone
3 participants
@shubhambhokare1 @gramalingam @justinchuby