Add test case for unsupported input-variable reuse in multi-output pattern matcher #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
reviewed
Jul 16, 2024
justinchuby
approved these changes
Jul 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
- Coverage 74.88% 74.83% -0.05%
==========================================
Files 242 242
Lines 25869 25886 +17
Branches 4665 4666 +1
==========================================
+ Hits 19371 19373 +2
- Misses 5628 5643 +15
Partials 870 870 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Jul 16, 2024
| @@ -281,6 +281,42 @@ def apply_pattern(op, x, **_): | |||
| self.assertEqual(len(graph.node), 2) | |||
| self.assertEqual(graph.node[0].op_type, "SinCos") | |||
|
|
|||
| @unittest.skip("Input variable reuse not supported yet") | |||
There was a problem hiding this comment.
We can xfail this so we know when it is fixed
justinchuby
reviewed
Jul 16, 2024
Test Results 24 files ± 0 24 suites ±0 1h 49m 53s ⏱️ + 5m 30s For more details on these failures, see this check. Results for commit 268dc3b. ± Comparison against base commit 581e998. ♻️ This comment has been updated with latest results. |
Co-authored-by: Justin Chu <[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi-output pattern does not support a useful case, where the pattern's input variables are reused elsewhere.
This PR adds a test-case illustrating the scenario. I was hoping that some changes in the in-progress PR #1636 by Xavier might fix this. But I don't think it does. Adding the test-case for now. Need to figure out how to support this.