Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aten_prod function #1724

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Add aten_prod function #1724

merged 4 commits into from
Jul 9, 2024

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Jul 8, 2024

The backward routine need aten_prod.dim_int function.
Todo: add test case for this function.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.65%. Comparing base (c74609c) to head (931059f).

Files Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
- Coverage   74.69%   74.65%   -0.05%     
==========================================
  Files         242      242              
  Lines       25861    25862       +1     
  Branches     4660     4661       +1     
==========================================
- Hits        19318    19308      -10     
- Misses       5674     5683       +9     
- Partials      869      871       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 8, 2024

Test Results

     24 files  ±     0      24 suites  ±0   3h 6m 15s ⏱️ + 3m 25s
  8 359 tests  -  2 163   6 868 ✅  - 1 731    1 490 💤  -    432  0 ❌  - 1  1 🔥 +1 
469 779 runs  +17 565  98 083 ✅ +2 564  371 695 💤 +15 001  0 ❌  - 1  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 9de26dc. ± Comparison against base commit d588d2c.

This pull request removes 2163 tests.
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_basic_defs
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_doc_string
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_if_defs
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_if_loop_defs
onnxscript._internal.analysis_test.TestAssignedVarAnalysis ‑ test_loop_defs
onnxscript._internal.analysis_test.TestExposedUses ‑ test_basic
onnxscript._internal.analysis_test.TestExposedUses ‑ test_called_function
onnxscript._internal.analysis_test.TestExposedUses ‑ test_doc_string
onnxscript._internal.analysis_test.TestExposedUses ‑ test_for_loop
onnxscript._internal.analysis_test.TestExposedUses ‑ test_if
…

♻️ This comment has been updated with latest results.

@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Jul 9, 2024
@xiaowuhu xiaowuhu merged commit 60f2d2c into main Jul 9, 2024
40 of 41 checks passed
@xiaowuhu xiaowuhu deleted the xiaowu/aten.prod branch July 9, 2024 06:57
@xiaowuhu xiaowuhu restored the xiaowu/aten.prod branch August 12, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants