Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rewriter input/output to be IR #1639

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Allow rewriter input/output to be IR #1639

merged 5 commits into from
Jun 19, 2024

Conversation

gramalingam
Copy link
Collaborator

@gramalingam gramalingam commented Jun 19, 2024

Allow rewriter input/output to be IR.

Eventually, we will keep all intermediate form in IR (switching to proto only at end).

Issue #1401

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.51%. Comparing base (523e466) to head (91355b4).

Files Patch % Lines
onnxscript/rewriter/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1639   +/-   ##
=======================================
  Coverage   76.50%   76.51%           
=======================================
  Files         234      234           
  Lines       24743    24743           
  Branches     4364     4364           
=======================================
+ Hits        18929    18931    +2     
+ Misses       4971     4969    -2     
  Partials      843      843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

     30 files  ±     0       30 suites  ±0   3h 20m 54s ⏱️ +51s
 10 516 tests + 2 185    8 635 ✅ +1 766    1 879 💤 +   419  2 ❌ +2 
576 204 runs   - 17 906  119 675 ✅  - 2 643  456 527 💤  - 15 263  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 91355b4. ± Comparison against base commit 523e466.

@gramalingam gramalingam merged commit c332202 into main Jun 19, 2024
44 of 47 checks passed
@gramalingam gramalingam deleted the rama/rewrite-ir branch June 19, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants