Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional attribute checking in matcher #1629

Merged
merged 10 commits into from
Jul 2, 2024

Merge branch 'main' into rama/matcher-attr

dcc6985
Select commit
Loading
Failed to load commit list.
Merged

Support optional attribute checking in matcher #1629

Merge branch 'main' into rama/matcher-attr
dcc6985
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 2, 2024 in 0s

75.58% (+0.00%) compared to 3244e92

View this Pull Request on Codecov

75.58% (+0.00%) compared to 3244e92

Details

Codecov Report

Attention: Patch coverage is 81.39535% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.58%. Comparing base (3244e92) to head (dcc6985).

Files Patch % Lines
onnxscript/rewriter/pattern.py 50.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1629   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files         240      240           
  Lines       25653    25690   +37     
  Branches     4615     4621    +6     
=======================================
+ Hits        19389    19418   +29     
- Misses       5385     5390    +5     
- Partials      879      882    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.