Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is for testing only #1621

Closed
wants to merge 8 commits into from
Closed

This is for testing only #1621

wants to merge 8 commits into from

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Jun 17, 2024

Copy xavier's PR, and this is just for testing.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 72.66140% with 415 lines in your changes missing coverage. Please review.

Project coverage is 76.23%. Comparing base (a1164f3) to head (604e64b).
Report is 16 commits behind head on main.

Files Patch % Lines
onnxscript/rewriter/llama_rule_sets.py 65.60% 36 Missing and 7 partials ⚠️
onnxscript/rewriter/generic_pattern.py 47.36% 32 Missing and 8 partials ⚠️
onnxscript/tools/memory_peak.py 71.87% 26 Missing and 10 partials ⚠️
onnxscript/tools/transformers_models/phi3.py 53.24% 30 Missing and 6 partials ⚠️
onnxscript/tools/transformers_models/mistral.py 50.00% 28 Missing and 7 partials ⚠️
onnxscript/ir/serde.py 35.55% 12 Missing and 17 partials ⚠️
onnxscript/function_libs/torch_lib/ops/core.py 87.04% 14 Missing and 11 partials ⚠️
...nxscript/tools/transformers_models/mistral_test.py 59.32% 23 Missing and 1 partial ⚠️
onnxscript/tools/transformers_models/phi3_test.py 61.90% 23 Missing and 1 partial ⚠️
onnxscript/tools/memory_peak_test.py 56.81% 18 Missing and 1 partial ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
- Coverage   76.59%   76.23%   -0.37%     
==========================================
  Files         230      240      +10     
  Lines       24419    25541    +1122     
  Branches     4251     4554     +303     
==========================================
+ Hits        18703    19470     +767     
- Misses       4897     5186     +289     
- Partials      819      885      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 17, 2024

Test Results

     30 files  ±      0      30 suites  ±0   1h 22m 45s ⏱️ - 1h 55m 55s
 11 533 tests  -     259   8 877 ✅  -  1 039    2 587 💤 +    712  69 ❌ +68 
195 538 runs   - 380 660  61 092 ✅  - 58 582  134 351 💤  - 322 172  95 ❌ +94 

For more details on these failures, see this check.

Results for commit 604e64b. ± Comparison against base commit dc31a6e.

This pull request removes 5065 and adds 4806 tests. Note that renamed tests count towards both.
docs.test.test_documentation_examples.TestDocumentationExample ‑ test_documentation_examples
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function__aten_convolution_onnx
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function__aten_scatter_reduce_onnx
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function__aten_zeros_like_onnx
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_alias
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_clone
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_conj
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_contiguous
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_detach
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_empty
…
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0000_test_convinteger_without_padding
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0000_test_slice
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0001_test_cosh_example
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0001_test_sqrt
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0002_test_cast_no_saturate_FLOAT_to_FLOAT8E5M2FNUZ
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0002_test_min_int32
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0003_test_col2im
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0003_test_sce_mean_weight
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0004_test_nllloss_NCd1d2_reduction_mean
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0004_test_reduce_sum_square_do_not_keepdims_example_expanded
…
This pull request removes 74 skipped tests and adds 849 skipped tests. Note that renamed tests count towards both.
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function__aten_convolution_onnx
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function__aten_scatter_reduce_onnx
tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__full_like_dtype_cpu_bool
tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__full_like_dtype_cpu_float16
tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__full_like_dtype_cpu_float32
tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__full_like_dtype_cpu_int32
tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__full_like_dtype_cpu_int64
tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__native_layer_norm_cpu_float16
tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__new_empty_dtype_cpu_bool
tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__new_empty_dtype_cpu_float16
…
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0002_test_cast_no_saturate_FLOAT_to_FLOAT8E5M2FNUZ
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0005_test_shape_start_1
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0012_test_qlinearmatmul_2D_int8_float16
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0014_test_optional_has_element_tensor_input
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0017_test_if_seq
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0018_test_image_decoder_decode_jpeg_bgr
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0019_test_max_int16
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0020_test_castlike_FLOAT_to_STRING
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0020_test_shape_start_1_end_2
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0021_test_unsqueeze_axis_2
…

♻️ This comment has been updated with latest results.

@xiaowuhu xiaowuhu marked this pull request as draft June 28, 2024 10:51
@xiaowuhu xiaowuhu requested review from justinchuby, titaiwangms and xadupre and removed request for justinchuby, titaiwangms and xadupre June 28, 2024 10:51
@xadupre
Copy link
Member

xadupre commented Jun 28, 2024

You should use this PR #1709 for your unit test.

It is weird to see changes not related to old commit.

@gramalingam
Copy link
Collaborator

Is this still active, or should we close this?

@xadupre xadupre closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants