[torchlib] Fix more signatures #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
added
the
topic: torch_lib
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
==========================================
- Coverage 75.84% 75.67% -0.18%
==========================================
Files 240 240
Lines 25500 25495 -5
Branches 4540 4549 +9
==========================================
- Hits 19341 19293 -48
- Misses 5269 5295 +26
- Partials 890 907 +17 ☔ View full report in Codecov by Sentry. |
Test Results 30 files ± 0 30 suites ±0 1h 13m 52s ⏱️ - 2h 6m 24s For more details on these failures, see this check. Results for commit b702136. ± Comparison against base commit c332202. This pull request removes 4817 and adds 2577 tests. Note that renamed tests count towards both.This pull request removes 19 skipped tests and adds 664 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
gramalingam
approved these changes
Jun 17, 2024
titaiwangms
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
CI failures unrelated |
xadupre
added a commit
to xadupre/onnxscript
that referenced
this pull request
Jun 24, 2024
Signed-off-by: Xavier Dupre <[email protected]>
justinchuby
added a commit
that referenced
this pull request
Jun 25, 2024
In the modularization pass in the exporter, a single node like `clone` can be lifted as a function. If we remove the only Identity node the lifted function will have no nodes. This violates the ONNX standard. Since removing identity nodes is fast, we are safe to include these identity nodes in the torchlib. onnxscript/tools/transformers_models/phi_test.py broke after #1613, it is fixed by this change. --------- Signed-off-by: Xavier Dupre <[email protected]> Co-authored-by: Justin Chu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix more signatures in torchlib that were previously overlooked