Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to check with onnxruntime-traning and transformers #1609

Merged
merged 23 commits into from
Jun 18, 2024

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Jun 14, 2024

No description provided.

Signed-off-by: Xavier Dupre <[email protected]>
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (d620466) to head (00043f7).

Current head 00043f7 differs from pull request most recent head 5051da2

Please upload reports for the commit 5051da2 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   76.63%   76.57%   -0.06%     
==========================================
  Files         232      232              
  Lines       24551    24561      +10     
  Branches     4320     4322       +2     
==========================================
- Hits        18814    18807       -7     
- Misses       4903     4911       +8     
- Partials      834      843       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xadupre added 4 commits June 14, 2024 14:22
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
@xadupre xadupre marked this pull request as ready for review June 14, 2024 13:55
Signed-off-by: Xavier Dupre <[email protected]>
xadupre added 7 commits June 14, 2024 16:27
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leverage nox to ensure we manage tests in a single place and allow the same test environment to be created locally.

Signed-off-by: Xavier Dupre <[email protected]>
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! There is a step in the ci job

      - name: Upload IR profiling results
        if: matrix.name == 'py311' || matrix.name == 'py311-onnx-weekly'
        uses: actions/upload-artifact@v3
        with:
          name: IR profiling results
          path: tests/ir/serde_test_profiles

That can be removed too.

@xadupre xadupre merged commit 677ba7f into microsoft:main Jun 18, 2024
41 of 43 checks passed
@justinchuby
Copy link
Collaborator

#1635

@xadupre xadupre self-assigned this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants