-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First series of P0 patterns to optimize llama #1490
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
+ Coverage 77.56% 77.60% +0.03%
==========================================
Files 216 218 +2
Lines 23339 23437 +98
Branches 4025 4046 +21
==========================================
+ Hits 18103 18188 +85
- Misses 4453 4459 +6
- Partials 783 790 +7 ☔ View full report in Codecov by Sentry. |
|
I tried to follow the recommandations. I get the following error:
CI is passing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with minor comments. Thanks!
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupre <[email protected]>
No description provided.