Add device to TorchScriptTensor #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
+ Coverage 76.84% 76.86% +0.01%
==========================================
Files 209 209
Lines 22461 22484 +23
Branches 3811 3816 +5
==========================================
+ Hits 17260 17282 +22
- Misses 4482 4483 +1
Partials 719 719 ☔ View full report in Codecov by Sentry. |
|
Lgtm. Could you create a test? |
justinchuby
approved these changes
Apr 30, 2024
Yes. could you point out the TorchScriptTensor related tests at? |
|
I would just create one here, if possible: https://github.com/microsoft/onnxscript/blob/main/onnxscript/function_libs/torch_lib/graph_building/graph_building_test.py |
justinchuby
pushed a commit
that referenced
this pull request
May 1, 2024
In torchlib, we have [device specific onnx function](https://github.com/microsoft/onnxscript/blob/8dba367fb000e3696c79b618638861b5cdf759dc/onnxscript/function_libs/torch_lib/ops/core.py#L5797-L5804), therefore, we need `TorchScriptTensor` to carry device property, so converter dispatcher can dispatch the best fitted function to the ATen op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In torchlib, we have device specific onnx function, therefore, we need
TorchScriptTensorto carry device property, so converter dispatcher can dispatch the best fitted function to the ATen op.