Pattern IR cleanup #1475
Pattern IR cleanup #1475
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @property | ||
| def name(self) -> str: | ||
| return self._name | ||
| def matches(self, item: T) -> bool: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
==========================================
- Coverage 76.85% 76.80% -0.06%
==========================================
Files 209 209
Lines 22476 22416 -60
Branches 3817 3814 -3
==========================================
- Hits 17275 17217 -58
+ Misses 4483 4471 -12
- Partials 718 728 +10 ☔ View full report in Codecov by Sentry. |
Test Results 30 files ± 0 30 suites ±0 3h 5m 34s ⏱️ - 7m 58s For more details on these failures, see this check. Results for commit 71a7875. ± Comparison against base commit 03b55e3. ♻️ This comment has been updated with latest results. |
| # if isinstance(x, list): | ||
| # if all(isinstance(i, (int, float)) for i in x): | ||
| # return Constant(x) | ||
| # raise ValueError("Only lists of int/float can be used as a ValuePattern") |
Check notice
Code scanning / CodeQL
Commented-out code Note
Co-authored-by: Justin Chu <[email protected]>
Continuation of the pattern cleanup. End goal is to have a small standalone pattern IR, and separate the matching algorithm (and other utilities like 'commute') out of the IR, allowing same IR to be used by different matching algorithms, which is yet to be done. This PR
TODO:
nodes) to GraphPattern (used by multi-output matcher, not single-output matcher).