Add one test failing for the optimizer after a model optimized and inlined #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
- Coverage 77.00% 76.99% -0.01%
==========================================
Files 209 209
Lines 22440 22440
Branches 3807 3807
==========================================
- Hits 17279 17277 -2
- Misses 4443 4445 +2
Partials 718 718 ☔ View full report in Codecov by Sentry. |
gramalingam
approved these changes
Apr 26, 2024
justinchuby
reviewed
Apr 26, 2024
justinchuby
approved these changes
Apr 26, 2024
|
@justinchuby @gramalingam Should we move tests under rewriter and optimizer to this folder? I feel like tests are scattered in the repo. |
|
Unit tests should stay with the modules, big tests should be in tests/. If a test inside rewriter/optimizer isn't named as somemodule_test, then we should move them imo. |
justinchuby
added a commit
that referenced
this pull request
May 1, 2024
…lined (#1465) Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.