Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rewriter][docs] Add Tutorial for Pattern-based Rewrites #1413

Merged
merged 9 commits into from
May 2, 2024
Merged

[rewriter][docs] Add Tutorial for Pattern-based Rewrites #1413

merged 9 commits into from
May 2, 2024

Conversation

shubhambhokare1
Copy link
Contributor

@shubhambhokare1 shubhambhokare1 commented Apr 19, 2024 •
edited
Loading

Add Tutorial for Pattern-based Rewrites

@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.86%. Comparing base (03b55e3) to head (f920f7c).

Files Patch % Lines
onnxscript/rewriter/onnxruntime/softmax.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
+ Coverage   76.85%   76.86%   +0.01%     
==========================================
  Files         209      209              
  Lines       22486    22476      -10     
  Branches     3817     3817              
==========================================
- Hits        17282    17277       -5     
+ Misses       4484     4481       -3     
+ Partials      720      718       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 19, 2024
View reviewed changes
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

Test Results

     30 files  ±0      30 suites  ±0   3h 13m 3s ⏱️ + 6m 39s
  3 904 tests ±0   2 422 ✅ +1    1 478 💤  - 1   4 ❌ +1 
564 363 runs  +1  88 062 ✅ +1  476 243 💤 ±0  58 ❌ +1 

For more details on these failures, see this check.

Results for commit 3af7236. ± Comparison against base commit 53e6832.

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 25, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@shubhambhokare1 shubhambhokare1 marked this pull request as ready for review April 25, 2024 18:38
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 25, 2024
View reviewed changes
docs/rewriter/examples/broadcast_matmul.py Fixed Show fixed Hide fixed
docs/rewriter/examples/broadcast_matmul.py Fixed Show fixed Hide fixed
docs/rewriter/examples/broadcast_matmul.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
@shubhambhokare1 shubhambhokare1 mentioned this pull request Apr 25, 2024
Open
@shubhambhokare1 shubhambhokare1 added documentation Improvements or additions to documentation topic: rewriter labels Apr 25, 2024
@shubhambhokare1 shubhambhokare1 self-assigned this Apr 25, 2024
@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/rewrite-tut1 branch 2 times, most recently from 3d8ff4c to 8f4e9a7 Compare April 30, 2024 12:03
gramalingam
gramalingam approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo one minor comment.

@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/rewrite-tut1 branch from cb10bdf to 8876bb9 Compare May 2, 2024 09:35
github-advanced-security[bot]
github-advanced-security bot found potential problems May 2, 2024
View reviewed changes
docs/rewriter/rewrite_patterns.md Fixed Show fixed Hide fixed
docs/rewriter/examples/broadcast_matmul.py Fixed Show fixed Hide fixed
docs/rewriter/examples/broadcast_matmul.py Fixed Show fixed Hide fixed
docs/rewriter/examples/broadcast_matmul.py Fixed Show fixed Hide fixed
docs/rewriter/examples/broadcast_matmul.py Fixed Show fixed Hide fixed
docs/rewriter/examples/broadcast_matmul.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
docs/rewriter/examples/erfgelu.py Fixed Show fixed Hide fixed
@titaiwangms titaiwangms self-requested a review May 2, 2024 16:06
@shubhambhokare1 shubhambhokare1 force-pushed the sbhokare/rewrite-tut1 branch from 3b6fac1 to e0c6d20 Compare May 2, 2024 21:11
gramalingam
gramalingam approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit comment

@shubhambhokare1 shubhambhokare1 merged commit b81a38a into main May 2, 2024
33 of 42 checks passed
@shubhambhokare1 shubhambhokare1 deleted the sbhokare/rewrite-tut1 branch May 2, 2024 21:40
@justinchuby
Copy link
Collaborator

Thanks for the nicely written doc! Published: https://onnxscript.ai/rewriter/rewrite_patterns.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby left review comments

@titaiwangms titaiwangms titaiwangms approved these changes

@gramalingam gramalingam gramalingam approved these changes

Assignees

@shubhambhokare1 shubhambhokare1

Labels
documentation Improvements or additions to documentation topic: rewriter
Projects
ONNX Script Review Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubhambhokare1 @justinchuby @gramalingam @titaiwangms