Upcast Celu for it to support more dtypes | feat(torchlib) #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
- Coverage 78.52% 78.23% -0.29%
==========================================
Files 118 118
Lines 15231 15237 +6
Branches 1635 1635
==========================================
- Hits 11960 11921 -39
- Misses 2891 2934 +43
- Partials 380 382 +2 ☔ View full report in Codecov by Sentry. |
justinchuby
added
topic: torch_lib
Test Results 18 files ± 0 18 suites ±0 1h 5m 14s ⏱️ - 4m 7s For more details on these failures, see this check. Results for commit 41f4d3e. ± Comparison against base commit e75da82. This pull request removes 263 and adds 270 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
BowenBao
approved these changes
Nov 16, 2023
| @@ -347,6 +350,14 @@ def aten_celu(self: FLOAT, alpha: float = 1.0) -> FLOAT: | |||
| return op.Celu(self, alpha=alpha) # op.Celu only support float32 | |||
|
|
|||
|
|
|||
| @torch_op("aten::celu") | |||
| def aten_celu_upcasted(self: TFloatUnlessFloat32, alpha: float = 1.0) -> TFloatUnlessFloat32: | |||
There was a problem hiding this comment.
nit: hmm we are also downcasting from double. I know I started with the term "upcast" in my original issue, but maybe we should name it something else to callout the onnx dtype limitation? aten_celu_dtype_hack? Just an idea and we might need to come up with something more formal if there are more cases.
There was a problem hiding this comment.
Updating to type_promoted. wdyt?
justinchuby
added
hold on merging
justinchuby
commented
Nov 20, 2023
justinchuby
commented
Nov 20, 2023
justinchuby
commented
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Celu only supports float in ONNX. This change adds the variant to support more floating types by manually adding casts in the function.