Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement aten::det | feat(torchlib) #1142

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Implement aten::det | feat(torchlib) #1142

merged 2 commits into from
Nov 9, 2023

Conversation

justinchuby
Copy link
Collaborator

No description provided.

@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1142 (89a61f2) into main (6200a29) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   78.40%   78.41%   +0.01%     
==========================================
  Files         118      118              
  Lines       15063    15062       -1     
  Branches     1607     1607              
==========================================
+ Hits        11810    11811       +1     
+ Misses       2882     2880       -2     
  Partials      371      371              
Files Coverage Δ
onnxscript/function_libs/torch_lib/ops/core.py 79.78% <ø> (+0.01%) ⬆️
onnxscript/function_libs/torch_lib/ops/linalg.py 68.96% <100.00%> (+0.90%) ⬆️
...ipt/tests/function_libs/torch_lib/ops_test_data.py 96.18% <ø> (ø)

@justinchuby justinchuby added the merge at lgtm Reviewers can merge when they approve label Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

Test Results

         18 files  ±  0         18 suites  ±0   1h 5m 59s ⏱️ +24s
  11 133 tests +  7    8 349 ✔️ +  7      2 731 💤 ±0       53 ±0 
159 540 runs  +63  36 740 ✔️ +63  120 733 💤 ±0  2 067 ±0 

For more details on these failures, see this check.

Results for commit 89a61f2. ± Comparison against base commit 6200a29.

This pull request removes 353 and adds 360 tests. Note that renamed tests count towards both.
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_108_aten_linalg_vector_norm
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_109_aten_linspace
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_110_aten_log
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_111_aten_le
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_112_aten_le_bool
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_113_aten_log10
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_114_aten_log1p
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_115_aten_special_log_softmax
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_116_aten_log2
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_117_aten_logaddexp
…
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_linalg_det
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_108_aten_linalg_det
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_109_aten_linalg_vector_norm
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_110_aten_linspace
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_111_aten_log
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_112_aten_le
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_113_aten_le_bool
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_114_aten_log10
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_115_aten_log1p
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_116_aten_special_log_softmax
…

@titaiwangms titaiwangms merged commit fdef96c into main Nov 9, 2023
27 of 31 checks passed
@titaiwangms titaiwangms deleted the justinchu/det branch November 9, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at lgtm Reviewers can merge when they approve topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants