Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement transpose for complex inputs | feat(torchlib) #1134

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

justinchuby
Copy link
Collaborator

Handle negative dimensions when transposing complex inputs.

@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1134 (41d4812) into main (9c5770b) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 84.61%.

❗ Current head 41d4812 differs from pull request most recent head cb4add2. Consider uploading reports for the commit cb4add2 to get more accurate results

@@           Coverage Diff           @@
##             main    #1134   +/-   ##
=======================================
  Coverage   78.38%   78.39%           
=======================================
  Files         118      118           
  Lines       15030    15043   +13     
  Branches     1601     1604    +3     
=======================================
+ Hits        11782    11793   +11     
- Misses       2878     2879    +1     
- Partials      370      371    +1     
Files Coverage Δ
...ipt/tests/function_libs/torch_lib/ops_test_data.py 96.15% <ø> (ø)
onnxscript/function_libs/torch_lib/ops/core.py 79.77% <84.61%> (+0.02%) ⬆️

Copy link
Contributor

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the original one also handle negative axis?

@justinchuby
Copy link
Collaborator Author

Should the original one also handle negative axis?

It does already

@justinchuby justinchuby merged commit 2930d03 into main Nov 7, 2023
23 of 27 checks passed
@justinchuby justinchuby deleted the justinchu/complex-transpose branch November 7, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants