Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement einsum | feat(torchlib) #1133

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Implement einsum | feat(torchlib) #1133

merged 5 commits into from
Nov 7, 2023

Conversation

justinchuby
Copy link
Collaborator

Implement einsum and fix a bug in the test code where we mistakenly treated str as a tensor. xfailed cases related to onnx/onnx#5739 and when input is int32.

Fixes #1130

@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1133 (e139b1c) into main (9c5770b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head e139b1c differs from pull request most recent head 011c357. Consider uploading reports for the commit 011c357 to get more accurate results

@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
+ Coverage   78.38%   78.40%   +0.01%     
==========================================
  Files         118      118              
  Lines       15030    15033       +3     
  Branches     1601     1601              
==========================================
+ Hits        11782    11786       +4     
+ Misses       2878     2877       -1     
  Partials      370      370              
Files Coverage Δ
onnxscript/function_libs/torch_lib/ops/core.py 79.78% <100.00%> (+0.03%) ⬆️
...t/tests/function_libs/torch_lib/ops_test_common.py 86.07% <100.00%> (ø)
...ipt/tests/function_libs/torch_lib/ops_test_data.py 96.18% <100.00%> (+0.02%) ⬆️

@justinchuby justinchuby merged commit 720ea34 into main Nov 7, 2023
24 of 27 checks passed
@justinchuby justinchuby deleted the justinchu/einsum-2 branch November 7, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[torchlib][feature request] aten::einsum
2 participants