Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace convert_element_type | fix(torchlib) #1129

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

justinchuby
Copy link
Collaborator

Set convert_element_type to trace_only because different branches return different dtype values.

Fixes #1128

Set convert_element_type to trace_only because different branches return different dtype values.
@justinchuby justinchuby changed the title Trace convert_element_type Trace convert_element_type | fix(torchlib) Nov 6, 2023
@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1129 (67406b5) into main (8eec5ae) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   78.38%   78.38%           
=======================================
  Files         118      118           
  Lines       15030    15030           
  Branches     1601     1601           
=======================================
  Hits        11782    11782           
  Misses       2878     2878           
  Partials      370      370           
Files Coverage Δ
onnxscript/function_libs/torch_lib/ops/prims.py 50.18% <100.00%> (ø)

Copy link

github-actions bot commented Nov 6, 2023

Test Results

         18 files         18 suites   1h 9m 10s ⏱️
  11 101 tests   8 330 ✔️     2 722 💤      49
159 093 runs  36 512 ✔️ 120 535 💤 2 046

For more details on these failures, see this check.

Results for commit 67406b5.

@justinchuby justinchuby merged commit 0f6f0fe into main Nov 6, 2023
27 of 31 checks passed
@justinchuby justinchuby deleted the justinchu/convert_element_type-fix branch November 6, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GoogleFnet output has unsupported type tensor(complex64)
2 participants