Add embedding_renorm code | feat(torchlib) #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaowuhu
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #1098 +/- ##
==========================================
+ Coverage 78.03% 78.10% +0.06%
==========================================
Files 115 115
Lines 14895 14932 +37
Branches 1581 1585 +4
==========================================
+ Hits 11623 11662 +39
+ Misses 2901 2900 -1
+ Partials 371 370 -1
|
Test Results 18 files ± 0 18 suites ±0 1h 17m 30s ⏱️ + 1m 0s For more details on these failures and errors, see this check. Results for commit 49fbcc6. ± Comparison against base commit 2a610c4. This pull request removes 147 and adds 153 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
justinchuby
reviewed
Oct 23, 2023
| unique_indices = op.Unique(indices) | ||
| unique_indices_Y = op.SequenceAt(unique_indices, 0) | ||
| # using _onnx private function because op.SrquenceAt(unique_indices, 0) cannot pass module checker | ||
| # The error message is: |
There was a problem hiding this comment.
Should we report this to ONNX?
There was a problem hiding this comment.
Filed an issue: onnx/onnx#5698
justinchuby
reviewed
Oct 23, 2023
justinchuby
changed the title
justinchuby
added
the
module: torchlib
justinchuby
reviewed
Oct 24, 2023
| """embedding_renorm(Tensor weight, Tensor indices, float max_norm, float norm_type) -> Tensor""" | ||
|
|
||
| unique_indices = op.Unique(indices) | ||
| unique_indices_Y = op.SequenceAt(unique_indices, 0) |
There was a problem hiding this comment.
Should we use slice here?
There was a problem hiding this comment.
Nop. It is an unequal length list.
There was a problem hiding this comment.
Fixed in #1123. The output is not a Sequence. That’s why the checker complained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.