Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix randint dtypes | test(torchlib) #1088

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

justinchuby
Copy link
Collaborator

Fix test input types for randint by replacing float input tests to integer inputs.

Fix test input types for randint by replacing float input tests to integer inputs.
@justinchuby justinchuby added the topic: torch_lib Related to the torch/aten function lib in development label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1088 (8a9c867) into main (1ee4ee1) will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
+ Coverage   77.80%   78.10%   +0.29%     
==========================================
  Files         115      115              
  Lines       14826    14826              
  Branches     1574     1574              
==========================================
+ Hits        11536    11580      +44     
+ Misses       2917     2875      -42     
+ Partials      373      371       -2     
Files Coverage Δ
...ript/tests/function_libs/torch_lib/extra_opinfo.py 98.64% <ø> (ø)

... and 3 files with indirect coverage changes

@github-actions
Copy link

Test Results

         18 files  +         12         18 suites  +12   1h 30m 12s ⏱️ + 56m 39s
  11 034 tests +    4 825    8 292 ✔️ +  3 904      2 723 💤 +     919       17 ±    0  2 🔥 +2 
186 981 runs  +119 454  43 314 ✔️ +27 617  142 216 💤 +90 869  1 449 +966  2 🔥 +2 

For more details on these failures and errors, see this check.

Results for commit 8a9c867. ± Comparison against base commit 1ee4ee1.

This pull request removes 12 and adds 4837 tests. Note that renamed tests count towards both.
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__ops_aten_randint_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__ops_aten_randint_like__dtype_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__ops_aten_randint_like_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__ops_aten_randint_like_low_dtype__dtype_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__ops_aten_randint_like_low_dtype_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyEagerCPU ‑ test_output_match_opinfo__ops_aten_randint_low_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyFullGraphCPU ‑ test_output_match_opinfo__ops_aten_randint_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyFullGraphCPU ‑ test_output_match_opinfo__ops_aten_randint_like__dtype_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyFullGraphCPU ‑ test_output_match_opinfo__ops_aten_randint_like_cpu_float32
onnxscript.tests.function_libs.torch_lib.ops_test.TestOutputConsistencyFullGraphCPU ‑ test_output_match_opinfo__ops_aten_randint_like_low_dtype__dtype_cpu_float32
…
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0000_test_convinteger_without_padding
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0000_test_dequantizelinear_e5m2
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0001_test_reduce_log_sum_default_expanded
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0001_test_sqrt
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0002_test_blackmanwindow_symmetric
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0002_test_min_int32
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0003_test_col2im
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0003_test_reduce_l2_negative_axes_keep_dims_example
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0004_test_nllloss_NCd1_ii
onnxscript.backend.onnx_export_test.TestOnnxBackEnd ‑ test_export2python_produces_correct_onnx_script_model_0004_test_reduce_sum_square_do_not_keepdims_example_expanded
…

Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@justinchuby justinchuby merged commit a981b8a into main Oct 11, 2023
@justinchuby justinchuby deleted the justinchu/rand-dtype-fix branch October 11, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants