Implement _log_softmax | feat(torchlib) #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
added
the
topic: torch_lib
BowenBao
reviewed
Oct 2, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
On it |
Codecov Report
@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
- Coverage 77.92% 77.91% -0.02%
==========================================
Files 115 115
Lines 14684 14706 +22
Branches 1558 1562 +4
==========================================
+ Hits 11443 11458 +15
- Misses 2872 2877 +5
- Partials 369 371 +2
|
Test Results 18 files ± 0 18 suites ±0 1h 13m 42s ⏱️ - 9m 42s For more details on these failures, see this check. Results for commit c33a9c0. ± Comparison against base commit b958002. This pull request removes 519 and adds 531 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Added tests |
BowenBao
approved these changes
Oct 2, 2023
|
|
||
| @torch_op("aten::_log_softmax") | ||
| def aten__log_softmax( | ||
| self: TFloatHighPrecision, dim: int, half_to_float: bool # pylint: disable=unused-argument |
There was a problem hiding this comment.
nit: very minor, should we do below to be consistent (saw in aten__softmax_half below) ?
del half_to_float # Unused
There was a problem hiding this comment.
This function is not trace only so we couldn't use del (not supported by onnxscript yet)
| ] | ||
|
|
||
| for (shape, dim), half_to_float in itertools.product(cases, (False,)): | ||
| # NOTE: softmax with half to float conversion is not supported on CPU |
There was a problem hiding this comment.
ORT doesn't run bfloat16 on cpu so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1077