Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
titaiwangms committed Nov 10, 2023
1 parent 6ec98e5 commit ea0534f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions onnxscript/function_libs/torch_lib/ops/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -5570,15 +5570,15 @@ def _aten_native_batch_norm_inference_onnx(
momentum=momentum,
training_mode=training,
)
# NOTE: mean and var are ommited in inference mode
# NOTE: mean and var are ommitted in inference mode

Check warning on line 5573 in onnxscript/function_libs/torch_lib/ops/core.py

View workflow job for this annotation

GitHub Actions / Optional Lint

[misspell] reported by reviewdog 🐶 "ommitted" is a misspelling of "omitted" Raw Output: ./onnxscript/function_libs/torch_lib/ops/core.py:5573:29: "ommitted" is a misspelling of "omitted"
# Cannot return 2 dup output, so have to do twice with different variable name
empty_mean = op.CastLike(op.Shape(input, start=0, end=0), norm)
empty_var = op.CastLike(op.Shape(input, start=0, end=0), norm)
return norm, empty_mean, empty_var


# TODO: This op is using duplicated code from aten_native_batch_norm,
# need to refactor it later.
# need to refactor it later. https://github.com/microsoft/onnxscript/issues/1125
# NOTE: This op is invoked by PyTorch Functionalization, and not in
# native_functions.yaml, It can be found in torch/_decomp/decompositions.py
@torch_op("aten::_native_batch_norm_legit_functional", trace_only=True)
Expand Down

0 comments on commit ea0534f

Please sign in to comment.