-
Notifications
You must be signed in to change notification settings - Fork 57
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Create PassBase, PassResult, PassManager, NodeTransformer for creating passes with the IR. - Implement the `remove_unused_functions` pass using this infrastructure. - Remove the `_invariance` module because it is unused. Future PRs: - Update rewriter to make it compatible with the `PassManager` ## TODO - Better docs for PassManager - Test PassManager Fix #1524
- Loading branch information
1 parent
a0fd224
commit d71b74f
Showing
9 changed files
with
344 additions
and
116 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# ------------------------------------------------------------------------- | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. | ||
# -------------------------------------------------------------------------- | ||
|
||
__all__ = [ | ||
"PassBase", | ||
"PassResult", | ||
"PassManager", | ||
"NodeTransformer", | ||
# Errors | ||
"InvariantError", | ||
"PreconditionError", | ||
"PostconditionError", | ||
"PassError", | ||
] | ||
|
||
from onnxscript.ir.passes._pass_infra import ( | ||
InvariantError, | ||
NodeTransformer, | ||
PassBase, | ||
PassError, | ||
PassManager, | ||
PassResult, | ||
PostconditionError, | ||
PreconditionError, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,256 @@ | ||
# ------------------------------------------------------------------------- | ||
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. | ||
# -------------------------------------------------------------------------- | ||
# | ||
# This module implements some APIs described in | ||
# https://pytorch.org/executorch/stable/compiler-custom-compiler-passes.html | ||
# for the ONNX IR. | ||
# The classes {PassResult and PassManager} are derived from | ||
# https://github.com/pytorch/pytorch/blob/1e47c7b11b312b47a621efd547f5c90081f0d9cb/torch/fx/passes/infra/pass_base.py#L12 | ||
# and | ||
# https://github.com/pytorch/pytorch/blob/1e47c7b11b312b47a621efd547f5c90081f0d9cb/torch/fx/passes/infra/pass_manager.py#L147 | ||
# The original code is licensed under the PyTorch License https://github.com/pytorch/pytorch/blob/main/LICENSE | ||
|
||
"""Passes infrastructure for the IR.""" | ||
|
||
from __future__ import annotations | ||
|
||
import dataclasses | ||
import logging | ||
from typing import Sequence | ||
|
||
__all__ = [ | ||
"NodeTransformer", | ||
"PassBase", | ||
"PassManager", | ||
"PassResult", | ||
# Errors | ||
"InvariantError", | ||
"PreconditionError", | ||
"PostconditionError", | ||
"PassError", | ||
] | ||
|
||
import abc | ||
|
||
from onnxscript import ir | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
class InvariantError(Exception): | ||
"""Raised when an invariant is violated.""" | ||
|
||
|
||
class PreconditionError(InvariantError): | ||
"""Raised when a precondition is violated.""" | ||
|
||
|
||
class PostconditionError(InvariantError): | ||
"""Raised when a postcondition is violated.""" | ||
|
||
|
||
class PassError(RuntimeError): | ||
"""Raised when an error occurs during a pass.""" | ||
|
||
|
||
@dataclasses.dataclass | ||
class PassResult: | ||
"""Result of a pass. | ||
Attributes: | ||
model: The transformed model. | ||
modified: Whether the model was modified. | ||
""" | ||
|
||
model: ir.Model | ||
modified: bool | ||
|
||
|
||
class PassBase(abc.ABC): | ||
"""Base class for all passes. | ||
Class attributes: | ||
in_place: Whether the pass modifies the model in place. | ||
""" | ||
|
||
in_place: bool = True | ||
|
||
def __call__(self, model: ir.Model) -> PassResult: | ||
return self.call(model) | ||
|
||
@abc.abstractmethod | ||
def call(self, model: ir.Model) -> PassResult: | ||
"""The main entry point for the pass.""" | ||
... | ||
|
||
def requires(self, model: ir.Model) -> None: | ||
"""Pre-conditions for the pass. | ||
This is optional to implement, will be called before call() if run by a pass manager. | ||
""" | ||
del model # Unused | ||
|
||
def ensures(self, model: ir.Model) -> None: | ||
"""Post-conditions for the pass. | ||
This is optional to implement, will be called after call() if run by a pass manager. | ||
""" | ||
del model # Unused | ||
|
||
|
||
class NodeTransformer(PassBase): | ||
"""NodeTransformer for the ONNX IR. | ||
An NodeTransformer is a pass that traverses the IR and performs some | ||
operation on the nodes. The operation can be anything, such as | ||
checking invariants, transforming the IR, or generating code. | ||
By default, the NodeTransformer updates the model in place. | ||
.. warning:: | ||
Users should not depend on this class before the warning is removed, because it is not stable. | ||
Attributes: | ||
model: ir.Model: The model being interpreted. | ||
scope (list[ir.Graph]): The current graph the NodeTransformer is running on. | ||
reversed (bool): Whether to traverse the graph in reverse order. | ||
modified (bool): Whether the model was modified. | ||
""" | ||
|
||
def __init__(self, reversed: bool = False): | ||
self._model: ir.Model | None = None | ||
self.scope: list[ir.Graph] = [] | ||
self.reversed = reversed | ||
self.modified: bool | None = None | ||
|
||
@property | ||
def model(self) -> ir.Model: | ||
"""Return the model being interpreted.""" | ||
if self._model is None: | ||
raise ValueError("Model is not set. The model is set during the pass execution.") | ||
return self._model | ||
|
||
def call(self, model: ir.Model) -> PassResult: | ||
self._model = model | ||
self.enter_pass() | ||
self._call_graph(self._model.graph) | ||
self.exit_pass() | ||
if self.modified is None: | ||
raise PassError("The modified attribute was not set. Please set it in the pass.") | ||
return PassResult(self._model, self.modified) | ||
|
||
def _call_graph(self, graph: ir.Graph): | ||
self.enter_graph(graph) | ||
self.scope.append(graph) | ||
iterable = reversed(graph) if self.reversed else graph | ||
for node in iterable: | ||
self.call_node_recursive(node) | ||
self.exit_graph(graph) | ||
self.scope.pop() | ||
|
||
def call_node_recursive(self, node: ir.Node): | ||
self.call_node(node) | ||
for attr in node.attributes.values(): | ||
if not isinstance(attr, ir.Attr): | ||
continue | ||
if attr.type == ir.AttributeType.GRAPH: | ||
self._call_graph(attr.value) | ||
elif attr.type == ir.AttributeType.GRAPHS: | ||
for graph in attr.value: | ||
self._call_graph(graph) | ||
|
||
def enter_pass(self): | ||
"""Called when entering the pass. Optional to implement.""" | ||
|
||
def exit_pass(self): | ||
"""Called when exiting the pass. Optional to implement.""" | ||
|
||
def enter_graph(self, graph: ir.Graph): | ||
"""Called when entering a graph. Optional to implement.""" | ||
del graph # Unused | ||
|
||
def exit_graph(self, graph: ir.Graph): | ||
"""Called when exiting a graph. Optional to implement.""" | ||
del graph # Unused | ||
|
||
@abc.abstractmethod | ||
def call_node(self, node: ir.Node): | ||
"""Called when visiting a node.""" | ||
... | ||
|
||
|
||
class PassManager: | ||
"""Pass manager for the IR. | ||
The PassManager is a callable that runs a sequence of passes on a model. | ||
Attributes: | ||
passes: The passes to run. | ||
check_invariants: Whether to check invariants before and after each pass. | ||
steps: The number of times to run the passes. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
passes: Sequence[PassBase], | ||
check_invariants: bool = False, | ||
steps: int = 1, | ||
): | ||
# TODO(justinchuby): Implement constraints | ||
self.passes = list(passes) | ||
self.check_invariants = check_invariants | ||
self.steps = steps | ||
|
||
def __call__(self, model: ir.Model) -> PassResult: | ||
"""Run the set of passes `steps` number of times or until the graph stops changing.""" | ||
overall_modified = False | ||
for step in range(self.steps): | ||
step_result = self._run_one_step(model, step) | ||
model = step_result.model | ||
modified = step_result.modified | ||
overall_modified = overall_modified or modified | ||
# If the graph no longer changes, then we can stop running these passes | ||
if not modified: | ||
logger.info("PassManager: No more graph changes detected after step %s", step) | ||
break | ||
return PassResult(model, overall_modified) | ||
|
||
def _run_one_step(self, model: ir.Model, step: int) -> PassResult: | ||
modified = False | ||
for i, pass_ in enumerate(self.passes): | ||
logger.debug("Running the %s-th pass '%s', (step %s)", i, pass_, step) | ||
|
||
# 1. Check preconditions | ||
if self.check_invariants: | ||
try: | ||
pass_.requires(model) | ||
except Exception as e: | ||
raise PreconditionError(f"Pre-condition failed for {pass_}") from e | ||
|
||
# 2. Run the pass | ||
try: | ||
pass_result = pass_(model) | ||
except Exception as e: | ||
prev_pass_names = [str(p) for p in self.passes[:i]] | ||
raise PassError( | ||
f"An error occurred when running the '{pass_}' pass after the " | ||
f"following passes: {prev_pass_names} during step {step}" | ||
) from e | ||
if not isinstance(pass_result, PassResult): | ||
raise TypeError( | ||
f"The result of the pass {pass_} should be type PassResult." | ||
"Please create one with ir.passes.PassResult()." | ||
) | ||
|
||
model = pass_result.model | ||
modified = modified or pass_result.modified | ||
|
||
# 3. Check postconditions | ||
if self.check_invariants: | ||
try: | ||
pass_.ensures(model) | ||
except Exception as e: | ||
raise PostconditionError(f"Post-condition failed for {pass_}") from e | ||
return PassResult(model, modified) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.