reviewdog [cpplint] report
reported by reviewdog 🐶
Findings (176)
include/onnxruntime/core/providers/tensorrt/tensorrt_provider_options.h|69| Lines should be <= 120 characters long [whitespace/line_length] [2]
include/onnxruntime/core/providers/tensorrt/tensorrt_provider_options.h|70| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/contrib_ops/cpu/bert/attention.cc|216| Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string] [5]
onnxruntime/contrib_ops/cpu/bert/attention.cc|216| Use operator ! instead of not [readability/alt_tokens] [2]
onnxruntime/contrib_ops/cpu/bert/attention.cc|217| Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string] [5]
onnxruntime/contrib_ops/cpu/bert/rotary_embedding_helper.h|114| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc|142| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc|234| Add #include for max [build/include_what_you_use] [4]
onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc|256| Add #include for unique_ptr<> [build/include_what_you_use] [4]
onnxruntime/contrib_ops/cuda/bert/multihead_attention.cc|48| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc|303| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/contrib_ops/rocm/bert/multihead_attention.cu|125| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
onnxruntime/contrib_ops/rocm/bert/multihead_attention.cu|126| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
onnxruntime/core/framework/graph_partitioner.cc|988| Add #include for string [build/include_what_you_use] [4]
onnxruntime/core/graph/contrib_ops/bert_defs.cc|1170| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/graph/contrib_ops/bert_defs.cc|1174| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/graph/contrib_ops/bert_defs.cc|1180| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/inc/mlas.h|1636| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/inc/mlas.h|1637| public: should be indented +1 space inside class MLAS_SBGEMM_POSTPROCESSOR [whitespace/indent] [3]
onnxruntime/core/mlas/inc/mlas.h|1644| Closing ) should be moved to the previous line [whitespace/parens] [2]
onnxruntime/core/mlas/inc/mlas.h|1655| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/inc/mlas.h|1656| public: should be indented +1 space inside class MLAS_SBGEMM_ACTIVATION_PROCESSOR [whitespace/indent] [3]
onnxruntime/core/mlas/inc/mlas.h|1657| Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]
onnxruntime/core/mlas/inc/mlas.h|1659| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/inc/mlas.h|1665| private: should be indented +1 space inside class MLAS_SBGEMM_ACTIVATION_PROCESSOR [whitespace/indent] [3]
onnxruntime/core/mlas/inc/mlas.h|1703| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|40| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/mlas/lib/sbgemm.h|84| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|102| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|111| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|115| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|116| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|140| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|143| Using C-style cast. Use reinterpret_cast<MLAS_SBGEMM_POSTPROCESSOR*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm.h|151| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|152| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|202| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/core/mlas/lib/sbgemm.h|205| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|208| Using C-style cast. Use reinterpret_cast<MLAS_SBGEMM_POSTPROCESSOR*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm.h|215| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|216| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|256| Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm.h|257| Closing ) should be moved to the previous line [whitespace/parens] [2]
onnxruntime/core/mlas/lib/sbgemm.h|261| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|261| Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm.h|268| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|291| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|302| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|325| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|329| Using C-style cast. Use reinterpret_cast<bfloat16_t*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm.h|333| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm.h|334| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm.h|345| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm.h|349| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm.h|350| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm.h|397| Closing ) should be moved to the previous line [whitespace/parens] [2]
onnxruntime/core/mlas/lib/sbgemm.h|242| Add #include for min [build/include_what_you_use] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|20| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|21| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|22| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|34| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|53| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|144| You don't need a ; after a } [readability/braces] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|261| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|262| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|263| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|264| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|268| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|269| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|270| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|273| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|274| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|277| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|315| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|332| Using C-style cast. Use reinterpret_cast<bfloat16_t*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|333| Using C-style cast. Use reinterpret_cast<bfloat16_t*>(...) instead [readability/casting] [4]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|339| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/mlas/lib/sbgemm_kernel_neon.cpp|340| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/core/providers/cpu/math/matmul.cc|186| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/core/providers/cpu/math/matmul.cc|247| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/core/providers/cpu/math/matmul.cc|251| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/providers/cpu/math/matmul.cc|259| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/core/providers/cpu/math/matmul.cc|259| If/else bodies with multiple statements require braces [readability/braces] [4]
onnxruntime/core/providers/cpu/math/matmul.cc|264| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/core/providers/cpu/math/matmul.cc|267| Using C-style cast. Use reinterpret_cast<float*>(...) instead [readability/casting] [4]
onnxruntime/core/providers/cpu/math/matmul.cc|262| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/core/providers/qnn/builder/onnx_ctx_model_helper.cc|95| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/qnn/builder/onnx_ctx_model_helper.cc|97| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/qnn/builder/onnx_ctx_model_helper.cc|101| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/qnn/builder/onnx_ctx_model_helper.cc|110| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/qnn/builder/onnx_ctx_model_helper.cc|116| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/qnn/builder/qnn_configs_helper.h|26| Add #include for move [build/include_what_you_use] [4]
onnxruntime/core/providers/qnn/qnn_execution_provider.cc|567| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/qnn/qnn_execution_provider.cc|603| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/qnn/qnn_execution_provider.cc|669| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/providers/qnn/qnn_execution_provider.h|62| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/qnn/qnn_execution_provider.h|73| Add #include for unique_ptr<> [build/include_what_you_use] [4]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.cc|265| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.cc|268| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.cc|278| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.cc|310| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h|19| For a static/global string constant, use a C style string instead: "static const char EPCONTEXT_WARNING[]". [runtime/string] [4]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h|20| Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string] [5]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h|20| Use operator && instead of and [readability/alt_tokens] [2]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h|21| Extra space before ( in function call [whitespace/parens] [4]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h|22| Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string] [5]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h|49| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/onnx_ctx_model_helper.h|60| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|1462| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|1467| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|1472| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|1582| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|1596| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|1599| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|1843| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|2355| Almost always, snprintf is better than strcpy [runtime/printf] [4]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|2884| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|3034| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|3039| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|3107| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|3577| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|3631| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc|3858| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider_custom_ops.cc|76| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/providers/tensorrt/tensorrt_execution_provider_custom_ops.cc|76| Add #include for make_unique<> [build/include_what_you_use] [4]
onnxruntime/core/session/inference_session.cc|1841| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1433| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1435| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1439| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1443| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1736| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1870| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1877| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1878| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/core/session/provider_bridge_ort.cc|1879| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/python/onnxruntime_pybind_state.cc|478| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/mlas/unittest/test_sbgemm.cpp|20| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.cpp|79| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/test/mlas/unittest/test_sbgemm.h|22| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.h|137| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.h|140| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.h|141| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.h|149| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.h|192| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.h|212| "public:" should be preceded by a blank line [whitespace/blank_line] [3]
onnxruntime/test/mlas/unittest/test_sbgemm.h|225| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/mlas/unittest/test_sbgemm.h|87| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.h|139| Add #include for min [build/include_what_you_use] [4]
onnxruntime/test/mlas/unittest/test_sbgemm.h|214| Add #include for string [build/include_what_you_use] [4]
onnxruntime/test/onnx/main.cc|63| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/onnx/main.cc|64| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/onnx/main.cc|66| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/optimizer/qdq_transformer_fastmath_test.cc|26| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/test/optimizer/qdq_transformer_fastmath_test.cc|28| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/test/optimizer/qdq_transformer_fastmath_test.cc|326| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/optimizer/qdq_transformer_fastmath_test.cc|369| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/optimizer/qdq_transformer_fastmath_test.cc|404| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/perftest/command_args_parser.cc|81| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/perftest/command_args_parser.cc|82| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/perftest/command_args_parser.cc|84| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/perftest/ort_test_session.cc|376| Add #include <unordered_set> for unordered_set<> [build/include_what_you_use] [4]
onnxruntime/test/providers/cpu/math/matmul_fastmath_test.cc|12| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/test/providers/cpu/math/matmul_fastmath_test.cc|48| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/providers/cpu/math/matmul_fastmath_test.cc|55| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/providers/cpu/math/matmul_fastmath_test.cc|62| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/providers/cpu/math/matmul_fastmath_test.cc|173| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/test/providers/cpu/math/matmul_fastmath_test.cc|175| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/providers/cpu/math/matmul_fastmath_test.cc|181| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/test/providers/cpu/math/matmul_fastmath_test.cc|183| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/providers/qnn/qnn_basic_test.cc|544| You don't need a ; after a } [readability/braces] [4]
onnxruntime/test/providers/qnn/qnn_basic_test.cc|694| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/providers/qnn/qnn_basic_test.cc|696| Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2]
onnxruntime/test/providers/qnn/qnn_basic_test.cc|697| Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2]
onnxruntime/test/providers/qnn/qnn_basic_test.cc|698| Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2]
onnxruntime/test/providers/tensorrt/tensorrt_basic_test.cc|436| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/test/providers/tensorrt/tensorrt_basic_test.cc|444| Lines should be <= 120 characters long [whitespace/line_length] [2]
Filtered Findings (818693)
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|50| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|54| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|149| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|154| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|325| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|347| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|413| Lines should be <= 120 characters long [whitespace/line_length] [2]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|763| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|768| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|774| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|781| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|782| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|783| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|792| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|797| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdC/CMakeCCompilerId.c|803| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|| No copyright message found. You should have a line: "Copyright [year] " [legal/copyright] [5]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|50| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|54| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|149| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|154| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|319| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|341| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|411| Lines should be <= 120 characters long [whitespace/line_length] [2]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|748| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|753| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|759| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|766| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|767| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|768| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|777| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|782| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|788| Missing space after , [whitespace/comma] [3]
build/Debug/CMakeFiles/3.28.1/CompilerIdCXX/CMakeCXXCompilerId.cpp|845| { should almost always be at the end of the previous line [whitespace/braces] [4]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/algorithm.h|22| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_ALGORITHM_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/algorithm.h|64| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_ALGORITHM_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/container.h|40| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_CONTAINER_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/algorithm/container.h|1730| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_ALGORITHM_CONTAINER_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/attributes.h|34| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_ATTRIBUTES_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/attributes.h|878| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_ATTRIBUTES_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once.h|25| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CALL_ONCE_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once.h|225| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CALL_ONCE_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once_test.cc|17| is an unapproved C++11 header. [build/c++11] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/call_once_test.cc|64| Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
build/Debug/_deps/abseil_cpp-src/absl/base/casts.h|24| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CASTS_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/casts.h|180| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CASTS_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/config.h|48| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CONFIG_H_ [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/config.h|1004| #endif line should be "#endif // BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CONFIG_H_" [build/header_guard] [5]
build/Debug/_deps/abseil_cpp-src/absl/base/config.h|1000| Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
build/Debug/_deps/abseil_cpp-src/absl/base/const_init.h|22| #ifndef header guard has wrong style, please use: BUILD_DEBUG__DEPS_ABSEIL_CPP_SRC_ABSL_BASE_CONST_INIT_H_ [build/header_guard] [5]
Annotations
Check warning on line 69 in include/onnxruntime/core/providers/tensorrt/tensorrt_provider_options.h
github-actions / cpplint
[cpplint] include/onnxruntime/core/providers/tensorrt/tensorrt_provider_options.h#L69
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
include/onnxruntime/core/providers/tensorrt/tensorrt_provider_options.h:69: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 70 in include/onnxruntime/core/providers/tensorrt/tensorrt_provider_options.h
github-actions / cpplint
[cpplint] include/onnxruntime/core/providers/tensorrt/tensorrt_provider_options.h#L70
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
include/onnxruntime/core/providers/tensorrt/tensorrt_provider_options.h:70: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 216 in onnxruntime/contrib_ops/cpu/bert/attention.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cpu/bert/attention.cc#L216
Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string] [5]
Raw output
onnxruntime/contrib_ops/cpu/bert/attention.cc:216: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string] [5]
Check warning on line 216 in onnxruntime/contrib_ops/cpu/bert/attention.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cpu/bert/attention.cc#L216
Use operator ! instead of not [readability/alt_tokens] [2]
Raw output
onnxruntime/contrib_ops/cpu/bert/attention.cc:216: Use operator ! instead of not [readability/alt_tokens] [2]
Check warning on line 217 in onnxruntime/contrib_ops/cpu/bert/attention.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cpu/bert/attention.cc#L217
Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string] [5]
Raw output
onnxruntime/contrib_ops/cpu/bert/attention.cc:217: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. Use C++11 raw strings or concatenation instead. [readability/multiline_string] [5]
Check warning on line 114 in onnxruntime/contrib_ops/cpu/bert/rotary_embedding_helper.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cpu/bert/rotary_embedding_helper.h#L114
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/contrib_ops/cpu/bert/rotary_embedding_helper.h:114: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 142 in onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc#L142
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Raw output
onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc:142: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Check warning on line 234 in onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc#L234
Add #include <algorithm> for max [build/include_what_you_use] [4]
Raw output
onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc:234: Add #include <algorithm> for max [build/include_what_you_use] [4]
Check warning on line 256 in onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc#L256
Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
Raw output
onnxruntime/contrib_ops/cpu/quantization/neural_speed_gemm.cc:256: Add #include <memory> for unique_ptr<> [build/include_what_you_use] [4]
Check warning on line 48 in onnxruntime/contrib_ops/cuda/bert/multihead_attention.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/bert/multihead_attention.cc#L48
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/contrib_ops/cuda/bert/multihead_attention.cc:48: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 303 in onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc#L303
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc:303: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 125 in onnxruntime/contrib_ops/rocm/bert/multihead_attention.cu
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/rocm/bert/multihead_attention.cu#L125
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Raw output
onnxruntime/contrib_ops/rocm/bert/multihead_attention.cu:125: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Check warning on line 126 in onnxruntime/contrib_ops/rocm/bert/multihead_attention.cu
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/rocm/bert/multihead_attention.cu#L126
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Raw output
onnxruntime/contrib_ops/rocm/bert/multihead_attention.cu:126: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Check warning on line 988 in onnxruntime/core/framework/graph_partitioner.cc
github-actions / cpplint
[cpplint] onnxruntime/core/framework/graph_partitioner.cc#L988
Add #include <string> for string [build/include_what_you_use] [4]
Raw output
onnxruntime/core/framework/graph_partitioner.cc:988: Add #include <string> for string [build/include_what_you_use] [4]
Check warning on line 1170 in onnxruntime/core/graph/contrib_ops/bert_defs.cc
github-actions / cpplint
[cpplint] onnxruntime/core/graph/contrib_ops/bert_defs.cc#L1170
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/core/graph/contrib_ops/bert_defs.cc:1170: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 1174 in onnxruntime/core/graph/contrib_ops/bert_defs.cc
github-actions / cpplint
[cpplint] onnxruntime/core/graph/contrib_ops/bert_defs.cc#L1174
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/core/graph/contrib_ops/bert_defs.cc:1174: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 1180 in onnxruntime/core/graph/contrib_ops/bert_defs.cc
github-actions / cpplint
[cpplint] onnxruntime/core/graph/contrib_ops/bert_defs.cc#L1180
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/core/graph/contrib_ops/bert_defs.cc:1180: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 1636 in onnxruntime/core/mlas/inc/mlas.h
github-actions / cpplint
[cpplint] onnxruntime/core/mlas/inc/mlas.h#L1636
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/core/mlas/inc/mlas.h:1636: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 1637 in onnxruntime/core/mlas/inc/mlas.h
github-actions / cpplint
[cpplint] onnxruntime/core/mlas/inc/mlas.h#L1637
public: should be indented +1 space inside class MLAS_SBGEMM_POSTPROCESSOR [whitespace/indent] [3]
Raw output
onnxruntime/core/mlas/inc/mlas.h:1637: public: should be indented +1 space inside class MLAS_SBGEMM_POSTPROCESSOR [whitespace/indent] [3]
Check warning on line 1644 in onnxruntime/core/mlas/inc/mlas.h
github-actions / cpplint
[cpplint] onnxruntime/core/mlas/inc/mlas.h#L1644
Closing ) should be moved to the previous line [whitespace/parens] [2]
Raw output
onnxruntime/core/mlas/inc/mlas.h:1644: Closing ) should be moved to the previous line [whitespace/parens] [2]
Check warning on line 1655 in onnxruntime/core/mlas/inc/mlas.h
github-actions / cpplint
[cpplint] onnxruntime/core/mlas/inc/mlas.h#L1655
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/core/mlas/inc/mlas.h:1655: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 1656 in onnxruntime/core/mlas/inc/mlas.h
github-actions / cpplint
[cpplint] onnxruntime/core/mlas/inc/mlas.h#L1656
public: should be indented +1 space inside class MLAS_SBGEMM_ACTIVATION_PROCESSOR [whitespace/indent] [3]
Raw output
onnxruntime/core/mlas/inc/mlas.h:1656: public: should be indented +1 space inside class MLAS_SBGEMM_ACTIVATION_PROCESSOR [whitespace/indent] [3]
Check warning on line 1657 in onnxruntime/core/mlas/inc/mlas.h
github-actions / cpplint
[cpplint] onnxruntime/core/mlas/inc/mlas.h#L1657
Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]
Raw output
onnxruntime/core/mlas/inc/mlas.h:1657: Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]
Check warning on line 1659 in onnxruntime/core/mlas/inc/mlas.h
github-actions / cpplint
[cpplint] onnxruntime/core/mlas/inc/mlas.h#L1659
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/core/mlas/inc/mlas.h:1659: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 1665 in onnxruntime/core/mlas/inc/mlas.h
github-actions / cpplint
[cpplint] onnxruntime/core/mlas/inc/mlas.h#L1665
private: should be indented +1 space inside class MLAS_SBGEMM_ACTIVATION_PROCESSOR [whitespace/indent] [3]
Raw output
onnxruntime/core/mlas/inc/mlas.h:1665: private: should be indented +1 space inside class MLAS_SBGEMM_ACTIVATION_PROCESSOR [whitespace/indent] [3]