reviewdog [cpplint] report
reported by reviewdog 🐶
Findings (234)
onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc|247| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc|248| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|19| Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|20| Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|21| Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|25| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|26| Found C++ system header after other header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|29| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|32| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|34| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|69| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|75| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|77| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|86| At least two spaces is best between code and comments [whitespace/comments] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h|78| Add #include for string [build/include_what_you_use] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h|21| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h|27| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h|28| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h|29| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|17| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|31| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|54| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|55| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|88| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|89| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|105| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|132| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|133| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|171| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|172| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|185| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc|185| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.h|19| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.h|21| Found C++ system header after other header. Should be: cutlass_heuristic.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.h|22| Found C++ system header after other header. Should be: cutlass_heuristic.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.h|23| Found C++ system header after other header. Should be: cutlass_heuristic.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.h|25| Should have a space between // and comment [whitespace/comments] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/epilogue_helpers.h|30| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/epilogue_helpers.h|37| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/epilogue_helpers.h|52| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/epilogue_helpers.h|53| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/epilogue_helpers.h|54| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/epilogue_helpers.h|55| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/epilogue_helpers.h|66| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/gemm_moe_problem_visitor.h|43| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/gemm_moe_problem_visitor.h|63| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/gemm_moe_problem_visitor.h|78| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/layout_traits_helper.h|38| Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/layout_traits_helper.h|79| private: should be indented +1 space inside struct MixedGemmArchTraits [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/layout_traits_helper.h|82| public: should be indented +1 space inside struct MixedGemmArchTraits [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/layout_traits_helper.h|107| private: should be indented +1 space inside struct MixedGemmArchTraits [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/layout_traits_helper.h|110| public: should be indented +1 space inside struct MixedGemmArchTraits [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/layout_traits_helper.h|133| private: should be indented +1 space inside struct MixedGemmArchTraits [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/layout_traits_helper.h|136| public: should be indented +1 space inside struct MixedGemmArchTraits [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/layout_traits_helper.h|153| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|43| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|44| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|77| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|78| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|97| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|111| public: should be indented +1 space inside struct MoeFCGemm [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|171| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|212| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|241| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|254| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|274| Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|284| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|289| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|290| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|310| public: should be indented +1 space inside struct MoeFCGemm [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|320| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|325| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|332| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|332| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|341| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|342| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|353| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|362| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|389| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|397| Using deprecated casting style. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|405| Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_cutlass_kernel.h|510| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels.h|20| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels.h|38| public: should be indented +1 space inside class MoeGemmRunner [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels.h|65| private: should be indented +1 space inside class MoeGemmRunner [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels.h|94| private: should be indented +1 space inside class MoeGemmRunner [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_fp16_fp16.cu|17| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_fp32_fp32.cu|17| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|32| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|33| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|34| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|35| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|39| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|40| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|42| Found C system header after other header. Should be: moe_gemm_kernels_template.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|43| Found C system header after other header. Should be: moe_gemm_kernels_template.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|44| Found C system header after other header. Should be: moe_gemm_kernels_template.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|45| Found C++ system header after other header. Should be: moe_gemm_kernels_template.h, c system, c++ system, other. [build/include_order] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|50| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|81| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|215| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|243| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|288| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|330| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|409| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|509| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|606| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|633| Lines should be <= 120 characters long [whitespace/line_length] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|644| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|645| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|667| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|668| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|687| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|687| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|704| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|704| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|721| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|721| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|739| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|801| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|875| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|148| Add #include for min [build/include_what_you_use] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|381| Add #include for string [build/include_what_you_use] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_gemm_kernels_template.h|743| Add #include for vector<> [build/include_what_you_use] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|32| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|53| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|110| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|111| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|173| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|374| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|375| Use int16/int64/etc, rather than the C type long [runtime/int] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|400| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|455| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|459| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|460| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|464| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|466| Using C-style cast. Use static_cast(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|470| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|487| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|505| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|513| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|513| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|527| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|528| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|540| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|546| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|581| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|588| Using C-style cast. Use reinterpret_cast<int*>(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|591| Using C-style cast. Use reinterpret_cast<T*>(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|593| Using C-style cast. Use reinterpret_cast<int64_t*>(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|595| Using C-style cast. Use reinterpret_cast<T*>(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|599| Using C-style cast. Use reinterpret_cast<T*>(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|601| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|601| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|628| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|637| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|637| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|642| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|642| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|647| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|647| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|666| Using C-style cast. Use reinterpret_cast<void*>(...) instead [readability/casting] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|734| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|764| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|793| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|827| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|852| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|853| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|872| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|872| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|875| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|875| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|906| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|933| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|961| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|976| An else should appear on the same line as the preceding } [whitespace/newline] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|976| If an else has a brace on one side, it should have it on both [readability/braces] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|963| Add #include for min [build/include_what_you_use] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.cu|1074| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|19| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|25| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|59| public: should be indented +1 space inside class CubKeyValueSorter [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|62| Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|77| private: should be indented +1 space inside class CubKeyValueSorter [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|140| public: should be indented +1 space inside class CutlassMoeFCRunner [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|194| private: should be indented +1 space inside class CutlassMoeFCRunner [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|202| private: should be indented +1 space inside class CutlassMoeFCRunner [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|221| public: should be indented +1 space inside class CutlassMoeFCRunner [whitespace/indent] [3]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|226| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_kernel.h|231| Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|64| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|84| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|101| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|116| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|122| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|123| Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|132| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|139| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|145| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|151| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|157| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|164| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|170| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|181| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|186| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|237| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|244| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|326| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/ft_moe/moe_problem_visitor.h|334| { should almost always be at the end of the previous line [whitespace/braces] [4]
onnxruntime/contrib_ops/cuda/moe/moe.cc|6| Include the directory when naming header files [build/include_subdir] [4]
onnxruntime/contrib_ops/cuda/moe/moe.cc|8| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
onnxruntime/contrib_ops/cuda/moe/moe.cc|9| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
onnxruntime/contrib_ops/cuda/moe/moe.cc|10| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
onnxruntime/contrib_ops/cuda/moe/moe.cc|30| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
... (Too many findings. Dropped some findings)
Annotations
Check warning on line 247 in onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc#L247
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc:247: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 248 in onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc#L248
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw output
onnxruntime/contrib_ops/cuda/cuda_contrib_kernels.cc:248: Lines should be <= 120 characters long [whitespace/line_length] [2]
Check warning on line 19 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L19
Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:19: Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
Check warning on line 20 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L20
Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:20: Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
Check warning on line 21 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L21
Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:21: Found C system header after C++ system header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
Check warning on line 25 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L25
Include the directory when naming header files [build/include_subdir] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:25: Include the directory when naming header files [build/include_subdir] [4]
Check warning on line 26 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L26
Found C++ system header after other header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:26: Found C++ system header after other header. Should be: common.h, c system, c++ system, other. [build/include_order] [4]
Check warning on line 29 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L29
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:29: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 32 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L32
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:32: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 34 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L34
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:34: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 69 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L69
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:69: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 75 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L75
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:75: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 77 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L77
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:77: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 86 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L86
At least two spaces is best between code and comments [whitespace/comments] [2]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:86: At least two spaces is best between code and comments [whitespace/comments] [2]
Check warning on line 78 in onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h#L78
Add #include <string> for string [build/include_what_you_use] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/common.h:78: Add #include <string> for string [build/include_what_you_use] [4]
Check warning on line 21 in onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h#L21
Include the directory when naming header files [build/include_subdir] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h:21: Include the directory when naming header files [build/include_subdir] [4]
Check warning on line 27 in onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h#L27
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h:27: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 28 in onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h#L28
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h:28: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
Check warning on line 29 in onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h#L29
Using deprecated casting style. Use static_cast<int>(...) instead [readability/casting] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/compute_occupancy.h:29: Using deprecated casting style. Use static_cast<int>(...) instead [readability/casting] [4]
Check warning on line 17 in onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc#L17
Include the directory when naming header files [build/include_subdir] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc:17: Include the directory when naming header files [build/include_subdir] [4]
Check warning on line 31 in onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc#L31
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc:31: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 54 in onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc#L54
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc:54: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 55 in onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc#L55
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc:55: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
Check warning on line 88 in onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc#L88
{ should almost always be at the end of the previous line [whitespace/braces] [4]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc:88: { should almost always be at the end of the previous line [whitespace/braces] [4]
Check warning on line 89 in onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc
github-actions / cpplint
[cpplint] onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc#L89
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
Raw output
onnxruntime/contrib_ops/cuda/moe/ft_moe/cutlass_heuristic.cc:89: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]