[WIP] Add QNN EP HTP shared memory allocator #23136
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… declarations and definitions for IAllocator::TensorAlloc().
…ion clean up callback
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
edgchen1
commented
Dec 19, 2024
| @@ -240,6 +245,9 @@ class QnnBackendManager { | |||
| const char* eventIdentifier); | |||
| #endif | |||
|
|
|||
| Status AddQnnContext(Qnn_ContextHandle_t context); | |||
| Status ReleaseQnnContextMemHandles(); | |||
There was a problem hiding this comment.
delete old declaration
edgchen1
commented
Dec 19, 2024
| @@ -63,6 +65,12 @@ size_t GetElementSizeByType(ONNXTensorElementDataType elem_type) { | |||
| return pos->second; | |||
| } | |||
|
|
|||
| size_t GetQnnTensorDataSize(gsl::span<const uint32_t> shape, Qnn_DataType_t element_type) { | |||
| ORT_ENFORCE(!shape.empty(), "Empty shape not allowed."); // TODO can we just treat empty shape as a scalar? | |||
There was a problem hiding this comment.
this check is copied from the original implementation here:
I'm not sure if it's needed
edgchen1
requested review from
skottmckay,
baijumeswani,
adrianlizarraga and
jywu-msft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds QNN EP HTP shared memory allocator.
The HTP shared memory allocator (
HtpSharedMemoryAllocator) calls the rpcmem shared library (libcdsprpc.so/dll) to allocate and free memory that can be shared between HTP and CPU.The allocator can be enabled by setting QNN EP option
enable_htp_shared_memory_allocatorto1.QNNExecutionProvider::CreatePreferredAllocators()will then return an instance ofHtpSharedMemoryAllocator.For each QNN context, we also need to register and unregister memory handles in order to use the HTP shared memory. This memory handle management is added to
QnnBackendManager, which also manages the QNN context handles.For more information about using HTP shared memory with QNN, see: https://docs.qualcomm.com/bundle/publicresource/topics/80-63442-50/htp_shared_buffer_tutorial.html#shared-buffer-tutorial
Limitations:
Motivation and Context
Improve performance by using HTP shared memory to avoid overhead from copying data between CPU and NPU.