Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreML] support coreml model cache #23065
base: main
Are you sure you want to change the base?
[CoreML] support coreml model cache #23065
Changes from 3 commits
1d1c874
b7888c4
f492fee
7b11848
4a5772f
b57aa28
723b2dd
4f0ac2a
781e42e
26775b4
89317c6
773dce0
e82f3e4
d3d25b9
d053dc0
2779e3d
c7194ad
8204e64
9c9374c
8faf178
e4e3547
728fbee
e49112c
d7b867c
7c466a1
d1e7633
a5ffe03
5518e38
70075e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should document what we do and don't do here.
If model changes user must do one of:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we can document fully in CoreML-ExecutionProvider.md and include a link to that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a const for the model metadata key name here. I'd vote for
COREML_CACHE_KEY
given the usage is CoreML specific.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
May the cache_key can be used by other EPs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is this required? Would be good to keep this as simple as possible. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, It's required.
require_static_shape_
or not will determinate the what the sub-graph looks like. Andgen_metadef_name
didn't check the input/output shape info.Check warning on line 21 in onnxruntime/core/providers/coreml/coreml_options.h
GitHub Actions / Optional Lint C++