Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcpkg.json - lock flatbuffer version #23046

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Dec 6, 2024

Description

Locking version introduced in:

static_assert(FLATBUFFERS_VERSION_MAJOR == 23 &&
FLATBUFFERS_VERSION_MINOR == 5 &&
FLATBUFFERS_VERSION_REVISION == 26,

Motivation and Context

Resolve issue for version >=1.20.
#22666

@mc-nv
Copy link
Contributor Author

mc-nv commented Dec 8, 2024

cc: @snnn

@snnn
Copy link
Member

snnn commented Dec 10, 2024

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline

@snnn
Copy link
Member

snnn commented Dec 10, 2024

/azp run Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline

@snnn
Copy link
Member

snnn commented Dec 10, 2024

/azp run Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@snnn
Copy link
Member

snnn commented Dec 10, 2024

Thanks for the fix. All the build pipelines passed, but I don't think the change is necessary. ORT's source code can be built with the latest flatbuffer as long as the corresponding auto-generated C++ source files have been regenerated. When you see " static_assert failed: 'Non-compatible flatbuffers version included'" , it means you need to regenerate the source file with the correct flatc. We have a Github Action that builds ORT with the latest flatbuffer and it works well.
I will merge it now, and see if we can improve it later. I hope we can provide better flexibility on choosing the dependencies versions.

@snnn snnn merged commit bf4d3e1 into microsoft:main Dec 10, 2024
77 checks passed
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
tarekziade pushed a commit to tarekziade/onnxruntime that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants