-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vcpkg.json - lock flatbuffer version #23046
Conversation
cc: @snnn |
/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline |
/azp run Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline |
/azp run Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline |
Azure Pipelines successfully started running 5 pipeline(s). |
Azure Pipelines successfully started running 6 pipeline(s). |
Azure Pipelines successfully started running 7 pipeline(s). |
Thanks for the fix. All the build pipelines passed, but I don't think the change is necessary. ORT's source code can be built with the latest flatbuffer as long as the corresponding auto-generated C++ source files have been regenerated. When you see " static_assert failed: 'Non-compatible flatbuffers version included'" , it means you need to regenerate the source file with the correct flatc. We have a Github Action that builds ORT with the latest flatbuffer and it works well. |
### Description Locking version introduced in: https://github.com/microsoft/onnxruntime/blob/03ea5dc495bfb48977d23705fa7cf184866a9f7f/onnxruntime/core/flatbuffers/schema/ort_training_checkpoint.fbs.h#L11-L13 ### Motivation and Context Resolve issue for version `>=1.20.` microsoft#22666
### Description Locking version introduced in: https://github.com/microsoft/onnxruntime/blob/03ea5dc495bfb48977d23705fa7cf184866a9f7f/onnxruntime/core/flatbuffers/schema/ort_training_checkpoint.fbs.h#L11-L13 ### Motivation and Context Resolve issue for version `>=1.20.` microsoft#22666
### Description Locking version introduced in: https://github.com/microsoft/onnxruntime/blob/03ea5dc495bfb48977d23705fa7cf184866a9f7f/onnxruntime/core/flatbuffers/schema/ort_training_checkpoint.fbs.h#L11-L13 ### Motivation and Context Resolve issue for version `>=1.20.` microsoft#22666
Description
Locking version introduced in:
onnxruntime/onnxruntime/core/flatbuffers/schema/ort_training_checkpoint.fbs.h
Lines 11 to 13 in 03ea5dc
Motivation and Context
Resolve issue for version
>=1.20.
#22666