Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js/webgpu] fix a bug in transpose shader #22997

Merged
merged 2 commits into from
Dec 4, 2024
Merged

[js/webgpu] fix a bug in transpose shader #22997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd8ee5
[js/webgpu] fix a bug in transpose shader
fs-eire Dec 3, 2024
e9f0203
Merge remote-tracking branch 'origin/main' into fs-eire/js-webgpu-fix…
fs-eire Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js/web/lib/wasm/jsep/webgpu/ops/transpose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ const permFunctionBody = (perm: number[], rank: number, input: IndicesHelper, ou
let reverseFunc = `fn perm(i: ${output.type.indices}) -> ${input.type.indices} {
var a: ${input.type.indices};`;
for (let i = 0; i < rank; ++i) {
reverseFunc += input.indicesSet('a', perm[i], `i[${i}]`);
// input indices and output indices should always be larger or equal to 2,
// so indexer is always valid to be used on `a` and `i`.
reverseFunc += `a[${perm[i]}]=i[${i}];`;
}
return (reverseFunc += 'return a;}');
};
Expand Down Expand Up @@ -71,7 +73,7 @@ export const createTransposeProgramInfo = (inputTensor: TensorView, permAttr: nu
const outputShape = getOutputShape(inputTensor.dims, perm);
let newInputShape = inputTensor.dims;
let newOutputShape = outputShape;
const transposeAsReshape = isTransposeReshape(perm, inputTensor.dims);
const transposeAsReshape = inputRank < 2 || isTransposeReshape(perm, inputTensor.dims);
let getShaderSource;
if (transposeAsReshape) {
getShaderSource = (shaderHelper: ShaderHelper) => {
Expand Down
Loading