[WebNN] Support negative steps for slice #22871
Open
+56
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It suddenly occurred to me that maybe other negative steps can also be supported with reverse+slice... I'll figure it out tomorrow |
shiyi9801
changed the title
Honry
reviewed
Nov 19, 2024
| @@ -50,9 +49,6 @@ Status SliceOpBuilder::AddToModelBuilderImpl(ModelBuilder& model_builder, | |||
| NodeAttrHelper helper(node); | |||
|
|
|||
| emscripten::val inputs = model_builder.GetOperand(input_defs[0]->Name()); | |||
There was a problem hiding this comment.
Please help rename this 'inputs' as 'input', legacy issue.
| emscripten::val reverse_options = emscripten::val::object(); | ||
| reverse_options.set("axes", emscripten::val::array(reverse_axes)); | ||
| reverse_options.set("label", node.Name() + "_reverse"); | ||
| reverse_output = model_builder.GetBuilder().call<emscripten::val>("reverse", inputs, reverse_options); |
There was a problem hiding this comment.
It'd be better to add data type check for reverse and split separately in a HasSupportedInputsImpl, in case it fails in old versions of Chrome which doesn't support reverse. You can do it in a follow-up. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slice with negative steps can be emulated by reverse+slice.