Enable Ort objects to be stored in a resizable std::vector #22608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianlizarraga
approved these changes
Oct 28, 2024
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this pull request
Nov 19, 2024
…#22608) ### Description <!-- Describe your changes. --> Allow some classes to be default constructed. The effect is the same as constructing it with nullptr. Make default ctor visible from the base classes. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Multiple customers complained that when storing Ort::Value in an instance of std::vector, vector can not be resized. We enable that with allowing it default constructed.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
…#22608) ### Description <!-- Describe your changes. --> Allow some classes to be default constructed. The effect is the same as constructing it with nullptr. Make default ctor visible from the base classes. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Multiple customers complained that when storing Ort::Value in an instance of std::vector, vector can not be resized. We enable that with allowing it default constructed.
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
…#22608) ### Description <!-- Describe your changes. --> Allow some classes to be default constructed. The effect is the same as constructing it with nullptr. Make default ctor visible from the base classes. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Multiple customers complained that when storing Ort::Value in an instance of std::vector, vector can not be resized. We enable that with allowing it default constructed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow some classes to be default constructed.
The effect is the same as constructing it with nullptr.
Make default ctor visible from the base classes.
Motivation and Context
Multiple customers complained that when storing Ort::Value
in an instance of std::vector, vector can not be resized.
We enable that with allowing it default constructed.