Fix reliability issues in LogAllSessions. #22568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple sessions and when ETW captureState / rundown is triggered.
… during mostly costly part of func
skottmckay
reviewed
Oct 29, 2024
skottmckay
approved these changes
Oct 29, 2024
sophies927
added
release:1.20.1
triage:approved
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this pull request
Nov 19, 2024
### Description Issue can happen with multiple sessions and when ETW captureState / rundown is triggered. Resolves use after free issue. Tested with local unit test creating/destroying multiple sessions while continually enabling & disabling ETW. This currently requires Admin prompt so not checking in ### Motivation and Context ORT should not crash
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
### Description Issue can happen with multiple sessions and when ETW captureState / rundown is triggered. Resolves use after free issue. Tested with local unit test creating/destroying multiple sessions while continually enabling & disabling ETW. This currently requires Admin prompt so not checking in ### Motivation and Context ORT should not crash
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
### Description Issue can happen with multiple sessions and when ETW captureState / rundown is triggered. Resolves use after free issue. Tested with local unit test creating/destroying multiple sessions while continually enabling & disabling ETW. This currently requires Admin prompt so not checking in ### Motivation and Context ORT should not crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue can happen with multiple sessions and when ETW captureState / rundown is triggered.
Resolves use after free issue.
Tested with local unit test creating/destroying multiple sessions while continually enabling & disabling ETW. This currently requires Admin prompt so not checking in
Motivation and Context
ORT should not crash