-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds support for Uint8ClampedArray #21985
Conversation
also need to add type declaration for uint8 in common\lib\tensor.ts |
can also add one test in js/common/unit-test/tensor/constructor-type.ts for:
|
seems still need code formatting |
To precisely explain the requirement of "support ClamppedUint8Array", it means "to allow creating uint8 tensors from ClamppedUint8Array". It does not change the underlying storage of a uint8 tensor (it is always Uint8Array). To break down, the work items are:
Allowing users to create a uint8 tensor from both |
@fs-eire I reverted the change to previous solution which has Uint8ClampedArray implemented as a uint8 datatype. However, I cannot seem to find a way to do this without including Please advise on if this is ok or what I can do differently. The current code passes the tests I've set up. |
test is failed. |
Fixes #21753