Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS/WebGPU] Support WASM64 #21836

Merged
merged 68 commits into from
Oct 25, 2024
Merged

[JS/WebGPU] Support WASM64 #21836

merged 68 commits into from
Oct 25, 2024

Conversation

satyajandhyala
Copy link
Contributor

Description

Support wasm64

Motivation and Context

Overcome memory limitations

@satyajandhyala
Initial changes to support wasm64.
60cd3db
@satyajandhyala
Lint
95d1707
@satyajandhyala
Add missing files.
b8d5db7
@satyajandhyala
Revert changes to conv3d_native_webgpu.ts
4726758
@satyajandhyala
Set ASYNCIFY=1 with MEMORY64.
7001f39
@satyajandhyala
Added Chrome Canary as a browser option.
29fc6c0
@satyajandhyala
Use wasm.PTR_SIZE instead of hardcoding to 4.
a6357e5
@satyajandhyala
Modified SIGNATURE_CONVERSION for OrtCreateTensor.
37a6d15
@satyajandhyala
Fix data type.
acc7e5a
@satyajandhyala
Use etValue/etValue instead of directly accessing heap.
3b46edd
@satyajandhyala
Use uintptr_t instead of uint32_t.
edcaa64
@satyajandhyala
Removed WASM_MEMORY64 macro
05d0426
@satyajandhyala
Clean up
af8a685
@satyajandhyala
Fix OrtRun integer arguments type.
757229d
@satyajandhyala
Added Number type conversions.
343f812
@satyajandhyala
Number type conversion.
7862a8f
@satyajandhyala
Added ASYNCIFY_IMPORT, and signature convertions.
0b4b040
@satyajandhyala
Removed unused settings.
786b58c
@satyajandhyala
Added missing function in SIGNATURE_CONVERSIONS.
4523acc
@satyajandhyala
clean-up
4d563c3
@satyajandhyala
Miscellaneous edits.
5f504c5
@satyajandhyala
Use Number cast to jsepRunKernel
5e07c97
@satyajandhyala
Use uint32_t instead of size_t.
c8b7d20
@satyajandhyala
Revert unnecessary compiler flags.
a31c5de
@satyajandhyala
Fixed SIGNATURE_CONVERSIONS
bfbb2d6
@satyajandhyala
minor change
603013c
@satyajandhyala
lint
ab91914
@satyajandhyala
Revert changes to gemm.h
a4fad86
@satyajandhyala
Keep static assertion guarded by ifdef.
11bbf26
@satyajandhyala
Switch back to using size_t instead of uint32_t
939a740
@guschmue
Copy link
Contributor

I can run my 90 model test to make sure it doesn't break anything on wasm32 as well as a test on wasm64.
We should merge it the tests are happy, no real risk since it is off by default.
To ship it as part of our npm (once chromium/stable has the flag) we need to come up with a way to package this but for now it is fine just building a wasm64 package imo.

@satyajandhyala
Copy link
Contributor Author

satyajandhyala commented Aug 27, 2024 •
edited
Loading

I can run my 90 model test to make sure it doesn't break anything on wasm32 as well as a test on wasm64. We should merge it the tests are happy, no real risk since it is off by default. To ship it as part of our npm (once chromium/stable has the flag) we need to come up with a way to package this but for now it is fine just building a wasm64 package imo.

With 3.1.59 emsdk, even a small test case fails if build flag -enable_wasm_memory64 is specified.

@satyajandhyala
Copy link
Contributor Author

Let me implement getHeapValue/setHeapValue internally to address perf concern.

@satyajandhyala
Copy link
Contributor Author

Let me implement getHeapValue/setHeapValue internally to address perf concern.

Planning to add any improvements later.

@satyajandhyala satyajandhyala merged commit 4ed5bec into main Oct 25, 2024
91 checks passed
@satyajandhyala satyajandhyala deleted the sajandhy/webgpu_support_wasm64 branch October 25, 2024 03:21
@snnn snnn mentioned this pull request Nov 6, 2024
Open
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
@satyajandhyala @fs-eire
[JS/WebGPU] Support WASM64 (microsoft#21836)
348cfa9 
### Description
Support wasm64



### Motivation and Context
Overcome memory limitations

---------

Co-authored-by: Yulong Wang <[email protected]>
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@satyajandhyala @fs-eire @ankitm3k
[JS/WebGPU] Support WASM64 (microsoft#21836)
b21dd35 
### Description
Support wasm64



### Motivation and Context
Overcome memory limitations

---------

Co-authored-by: Yulong Wang <[email protected]>
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@satyajandhyala @fs-eire @ankitm3k
[JS/WebGPU] Support WASM64 (microsoft#21836)
991e8fb 
### Description
Support wasm64



### Motivation and Context
Overcome memory limitations

---------

Co-authored-by: Yulong Wang <[email protected]>
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@satyajandhyala @fs-eire @ankitm3k
[JS/WebGPU] Support WASM64 (microsoft#21836)
25f8648 
### Description
Support wasm64



### Motivation and Context
Overcome memory limitations

---------

Co-authored-by: Yulong Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guschmue guschmue guschmue approved these changes

@fs-eire fs-eire fs-eire approved these changes

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satyajandhyala @guschmue @fs-eire