Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorRT EP] Add null_ptr check to avoid crash when running session which was failed to generate trt_engine previously #21621

Merged
merged 7 commits into from
Aug 9, 2024
Merged

[TensorRT EP] Add null_ptr check to avoid crash when running session which was failed to generate trt_engine previously #21621

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f6efdc
check if trt_engine invalid
yf711 Jul 30, 2024
cfd44a7
update
yf711 Jul 30, 2024
ad3dd46
remove redundant
yf711 Aug 5, 2024
785d350
lint
yf711 Aug 5, 2024
ac19d4e
comments applied
yf711 Aug 6, 2024
cbbd2fb
Merge branch 'main' into yifanl/nullptr_chk
yf711 Aug 7, 2024
1ef474d
Merge branch 'main' into yifanl/nullptr_chk
yf711 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions onnxruntime/core/providers/tensorrt/tensorrt_execution_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3752,6 +3752,11 @@ Status TensorrtExecutionProvider::CreateNodeComputeInfoFromGraph(const GraphView
trt_context = trt_state->context->get();
}

// Check before using trt_engine
if (trt_engine == nullptr) {
return ORT_MAKE_STATUS(ONNXRUNTIME, EP_FAIL, "No engine is found.");
}

// Get input and output binding names
int total_bindings = trt_engine->getNbIOTensors();
std::vector<char const*> input_binding_names, output_binding_names;
Expand Down Expand Up @@ -4075,6 +4080,11 @@ Status TensorrtExecutionProvider::CreateNodeComputeInfoFromPrecompiledEngine(con
Ort::ThrowOnError(api->KernelContext_GetGPUComputeStream(context, &cuda_stream));
cudaStream_t stream = static_cast<cudaStream_t>(cuda_stream);

// Check before using trt_engine
if (trt_engine == nullptr) {
return ORT_MAKE_STATUS(ONNXRUNTIME, EP_FAIL, "No engine is found.");
}

// Get input and output binding names
int total_bindings = trt_engine->getNbIOTensors();
std::vector<char const*> input_binding_names, output_binding_names;
Expand Down
Loading