Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to apple packaging #21611

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Updates to apple packaging #21611

merged 1 commit into from
Aug 5, 2024

Conversation

skottmckay
Copy link
Contributor

Description

Add ability to test packaging without rebuilding every time.
Add ability to comment out some platforms/architectures without the scripts to assemble the c/obj-c packages breaking.
Update a couple of commands to preserve symlinks.

Motivation and Context

Make debugging packaging issues faster.
Creates correct package for mac-catalyst and doesn't require setting symlinks via bash script.

Add ability to comment out some platforms/architectures without the scripts to assemble the c/obj-c packages breaking.
Update a couple of commands to preserve symlinks.
@skottmckay skottmckay requested a review from vraspar August 5, 2024 01:56
@skottmckay skottmckay requested a review from a team as a code owner August 5, 2024 01:56
Copy link
Contributor

@vraspar vraspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I was wondering if in future, we should refactor the apple packaging pipeline a bit, and maybe use common utility function for moving/copying files, zipping files

@skottmckay skottmckay merged commit bcc01ac into main Aug 5, 2024
105 of 112 checks passed
@skottmckay skottmckay deleted the skottmckay/ApplePackagingTweak branch August 5, 2024 22:50
@skottmckay skottmckay added the release:1.19.0 Cherry pick to ORT 1.19 label Aug 7, 2024
@skottmckay
Copy link
Contributor Author

looks good to me. I was wondering if in future, we should refactor the apple packaging pipeline a bit, and maybe use common utility function for moving/copying files, zipping files

if we can refactor to simplify we should definitely do that

prathikr pushed a commit that referenced this pull request Aug 7, 2024
### Description
<!-- Describe your changes. -->
Add ability to test packaging without rebuilding every time.
Add ability to comment out some platforms/architectures without the
scripts to assemble the c/obj-c packages breaking.
Update a couple of commands to preserve symlinks.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Make debugging packaging issues faster.
Creates correct package for mac-catalyst and doesn't require setting
symlinks via bash script.
prathikr pushed a commit that referenced this pull request Aug 9, 2024
### Description
<!-- Describe your changes. -->
Add ability to test packaging without rebuilding every time.
Add ability to comment out some platforms/architectures without the
scripts to assemble the c/obj-c packages breaking.
Update a couple of commands to preserve symlinks.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Make debugging packaging issues faster.
Creates correct package for mac-catalyst and doesn't require setting
symlinks via bash script.
@prathikr prathikr added the cherry-picked Cherry-picked for a cherrypicks branch label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked Cherry-picked for a cherrypicks branch release:1.19.0 Cherry pick to ORT 1.19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants