Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed in combining per-channel data #21563

Merged

Conversation

duanshengliu
Copy link
Contributor

Description

Improve speed in combining per-channel data for using a single np.concatenate instead of multiple np.concatenates within a for loop.

Motivation and Context

Fix the issue #21562

@duanshengliu
Copy link
Contributor Author

yufenglee
yufenglee previously approved these changes Jul 31, 2024
@yufenglee
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@yufenglee
Copy link
Member

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Android CI Pipeline

@yufenglee
Copy link
Member

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@yufenglee
Copy link
Member

/azp run Linux Android Emulator QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yufenglee
Copy link
Member

Hi @duanshengliu, you need to sign the license/cla to move forward.

@duanshengliu duanshengliu force-pushed the improve-combine-per-channel-data-speed branch 2 times, most recently from 00fcfdb to 3b77cf5 Compare August 5, 2024 13:49
@duanshengliu
Copy link
Contributor Author

Hi @duanshengliu, you need to sign the license/cla to move forward.

Hi @yufenglee, I have updated the signature and the license/cla check has passed now. Could you please run CI again? Thanks.

@yufenglee
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@yufenglee
Copy link
Member

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Android CI Pipeline

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@yufenglee
Copy link
Member

/azp run Linux Android Emulator QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yufenglee
Copy link
Member

/azp run Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

Copy link

No pipelines are associated with this pull request.

@yufenglee
Copy link
Member

/azp run Windows GPU DML CI Pipeline

Copy link

No pipelines are associated with this pull request.

@yufenglee
Copy link
Member

could you please sync to the main branch? Looks like Windows GPU CUDA CI Pipeline is not in your branch.

@duanshengliu duanshengliu force-pushed the improve-combine-per-channel-data-speed branch 2 times, most recently from ef8c09e to 00fcfdb Compare August 5, 2024 17:19
@duanshengliu
Copy link
Contributor Author

could you please sync to the main branch? Looks like Windows GPU CUDA CI Pipeline is not in your branch.

Done,please try again.

@duanshengliu duanshengliu requested a review from yufenglee August 5, 2024 17:31
@yufenglee
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@yufenglee
Copy link
Member

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Android CI Pipeline

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@yufenglee
Copy link
Member

/azp run Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Linux Android Emulator QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 10 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yufenglee
Copy link
Member

/azp run Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Linux Android Emulator QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@duanshengliu
Copy link
Contributor Author

Hi @yufenglee, could you please review it again? By the way, please take a look at #21347 (comment)

@yufenglee yufenglee merged commit b95aa05 into microsoft:main Aug 6, 2024
78 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants