Remove unused parameters from win-ci-vs-2022-job.yml #21530
Conversation
|
The IsTraining parameter is deprecated in #14055. But why the other parameter went unused? It should be used in C# tests. Are we running C# EP tests ? A few our C# source files use the USE_CUDA macro: https://github.com/search?q=repo%3Amicrosoft%2Fonnxruntime+USE_CUDA+language%3AC%23+&type=code Do they get tested? |
The |
# Conflicts: # tools/ci_build/github/azure-pipelines/win-gpu-ci-pipeline.yml
|
I just checked the latest running log of the "Zip-Nuget-Java-Nodejs Packaging Pipeline". It seems some GPU related tests are skipped. For example, the "Run End to End Test (C#) .Net Core x64" step in NuGet_Test_Win_GPU says: |
|
|
|
Our "Windows GPU CUDA CI Pipeline" also doesn't run C# GPU tests. Could you please help fix it? |
| @@ -35,9 +31,6 @@ parameters: | |||
| type: boolean | |||
| default: true | |||
|
|
|||
| - name: ORT_EP_NAME | |||
There was a problem hiding this comment.
I am not sure if this parameter is still needed or not. Because now we are not running CUDA C# tests. Maybe we should keep this parameter here and use it correctly.
There was a problem hiding this comment.
The reference of ORT_EP_NAME got removed in PR #13637 . I think that was an accident.
There was a problem hiding this comment.
@skottmckay said:
If you use --build_csharp (we do on line 145), I believe onnxruntime_csharp.cmake will update csharp/Directory.Build.props, which sets which EPs are enabled via 'USE_xxx' defines.
This is a better setup as it a) allows an arbitrary combination of EPs to be used and b) doesn't use a /p property which is a global value that overrides any values set in csproj files.
However, it seems something was missing.
Description
Remove unused parameters from win-ci-vs-2022-job.yml:
name: isTraining
name: ORT_EP_NAME
Motivation and Context
Clean up