Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Update argMax/argMin to adapt to latest spec #21452

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[WebNN EP] Update argMax/argMin to adapt to latest spec #21452

merged 1 commit into from
Jul 26, 2024

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Jul 23, 2024 •
edited
Loading

WebNN spec recently changes the definition of argMax/argMin:

  • Remove selectLastIndex option, let backends decide to select the last index or not.
  • Move axes option to axis input

@Honry
Copy link
Contributor Author

Honry commented Jul 23, 2024

@fdwr, @guschmue, PTAL, thanks!

Corresponding Chromium CL for moving axes option to axis input will land soon: https://chromium-review.googlesource.com/c/chromium/src/+/5721028

@fdwr
Copy link
Contributor

fdwr commented Jul 23, 2024

Corresponding Chromium CL for moving axes option to axis input will land soon: https://chromium-review.googlesource.com/c/chromium/src/+/5721028

And it's merged.

fdwr
fdwr approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr added the ep:WebNN WebNN execution provider label Jul 23, 2024
@fdwr
Copy link
Contributor

fdwr commented Jul 23, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jul 23, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jul 23, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@guschmue
Copy link
Contributor

can you merge with main? There have been a few changes to fix ci.

@Honry Honry force-pushed the argmaxmin-other-options branch from 66fb0ad to 63aefbc Compare July 24, 2024 01:37
@Honry
Copy link
Contributor Author

Honry commented Jul 24, 2024

can you merge with main? There have been a few changes to fix ci.

@guschmue, done.

@guschmue
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@guschmue
Copy link
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@Honry
Copy link
Contributor Author

Honry commented Jul 25, 2024

can you merge with main? There have been a few changes to fix ci.

@guschmue, done.

@guschmue, the CI still fails, do I need to try rebase again?

@Honry
[WebNN EP] Update argMax/argMin to adapt to latest spec
1b42e12 
WebNN spec recently changes the definition of argMax/argMin:
- Remove selectLastIndex option, let backends decide the selected the index.
- Move axes option to axis input
@Honry Honry force-pushed the argmaxmin-other-options branch from 63aefbc to 1b42e12 Compare July 25, 2024 05:34
@fdwr
Copy link
Contributor

fdwr commented Jul 25, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jul 25, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Jul 25, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Jul 25, 2024

/azp run Windows GPU CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fdwr fdwr merged commit b6b2930 into microsoft:main Jul 26, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guschmue guschmue guschmue approved these changes

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @fdwr @guschmue